Merge pull request #1353 from json-api-dotnet/drop-postgres-pwd-env-var

Remove logic to obtain PostgreSQL password from environment variable

Author: bkoelman

src/Examples/DatabasePerTenantExample/Data/AppDbContext.cs

@@ -44,8 +44,7 @@ private string GetConnectionString()
             throw GetErrorForInvalidTenant(tenantName);
         }
 
-        string postgresPassword = Environment.GetEnvironmentVariable("PGPASSWORD") ?? "postgres";
-        return connectionString.Replace("###", postgresPassword);
+        return connectionString;
     }
 
     private string? GetTenantName()

src/Examples/DatabasePerTenantExample/appsettings.json

@@ -1,8 +1,8 @@
 {
   "ConnectionStrings": {
-    "Default": "Host=localhost;Database=DefaultTenantDb;User ID=postgres;Password=###;Include Error Detail=true",
-    "AdventureWorks": "Host=localhost;Database=AdventureWorks;User ID=postgres;Password=###;Include Error Detail=true",
-    "Contoso": "Host=localhost;Database=Contoso;User ID=postgres;Password=###;Include Error Detail=true"
+    "Default": "Host=localhost;Database=DefaultTenantDb;User ID=postgres;Password=postgres;Include Error Detail=true",
+    "AdventureWorks": "Host=localhost;Database=AdventureWorks;User ID=postgres;Password=postgres;Include Error Detail=true",
+    "Contoso": "Host=localhost;Database=Contoso;User ID=postgres;Password=postgres;Include Error Detail=true"
   },
   "Logging": {
     "LogLevel": {

src/Examples/JsonApiDotNetCoreExample/Program.cs

@@ -49,7 +49,7 @@ static void ConfigureServices(WebApplicationBuilder builder)
 
     builder.Services.AddDbContext<AppDbContext>(options =>
     {
-        string? connectionString = GetConnectionString(builder.Configuration);
+        string? connectionString = builder.Configuration.GetConnectionString("Default");
         options.UseNpgsql(connectionString);
 
         SetDbContextDebugOptions(options);
@@ -73,12 +73,6 @@ static void ConfigureServices(WebApplicationBuilder builder)
     }
 }
 
-static string? GetConnectionString(IConfiguration configuration)
-{
-    string postgresPassword = Environment.GetEnvironmentVariable("PGPASSWORD") ?? "postgres";
-    return configuration.GetConnectionString("Default")?.Replace("###", postgresPassword);
-}
-
 [Conditional("DEBUG")]
 static void SetDbContextDebugOptions(DbContextOptionsBuilder options)
 {

src/Examples/JsonApiDotNetCoreExample/appsettings.json

@@ -1,6 +1,6 @@
 {
   "ConnectionStrings": {
-    "Default": "Host=localhost;Database=JsonApiDotNetCoreExample;User ID=postgres;Password=###;Include Error Detail=true"
+    "Default": "Host=localhost;Database=JsonApiDotNetCoreExample;User ID=postgres;Password=postgres;Include Error Detail=true"
   },
   "Logging": {
     "LogLevel": {

test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Transactions/AtomicTransactionConsistencyTests.cs

@@ -27,10 +27,8 @@ public AtomicTransactionConsistencyTests(IntegrationTestContext<TestableStartup<
             services.AddResourceRepository<MusicTrackRepository>();
             services.AddResourceRepository<LyricRepository>();
 
-            string postgresPassword = Environment.GetEnvironmentVariable("PGPASSWORD") ?? "postgres";
-
             string dbConnectionString =
-                $"Host=localhost;Database=JsonApiTest-Extra-{Guid.NewGuid():N};User ID=postgres;Password={postgresPassword};Include Error Detail=true";
+                $"Host=localhost;Database=JsonApiTest-Extra-{Guid.NewGuid():N};User ID=postgres;Password=postgres;Include Error Detail=true";
 
             services.AddDbContext<ExtraDbContext>(options => options.UseNpgsql(dbConnectionString));
         });

test/TestBuildingBlocks/IntegrationTestContext.cs

@@ -64,10 +64,7 @@ protected override HttpClient CreateClient()
 
     private WebApplicationFactory<TStartup> CreateFactory()
     {
-        string postgresPassword = Environment.GetEnvironmentVariable("PGPASSWORD") ?? "postgres";
-
-        string dbConnectionString =
-            $"Host=localhost;Database=JsonApiTest-{Guid.NewGuid():N};User ID=postgres;Password={postgresPassword};Include Error Detail=true";
+        string dbConnectionString = $"Host=localhost;Database=JsonApiTest-{Guid.NewGuid():N};User ID=postgres;Password=postgres;Include Error Detail=true";
 
         var factory = new IntegrationTestWebApplicationFactory();