Skip to content

Commit 55ee6f4

Browse files
bkoelmanbkoelman
committed
Fixed: the 'first' link should not be required, because JsonApiDotNetCore omits it when no resources are returned
1 parent 6f89ded commit 55ee6f4

File tree

11 files changed

+0
-38
lines changed

11 files changed

+0
-38
lines changed

‎src/JsonApiDotNetCore.OpenApi/JsonApiObjects/Links/LinksInResourceCollectionDocument.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ internal sealed class LinksInResourceCollectionDocument
1414
[JsonPropertyName("describedby")]
1515
public string Describedby { get; set; } = null!;
1616

17-
[Required]
1817
[JsonPropertyName("first")]
1918
public string First { get; set; } = null!;
2019

‎src/JsonApiDotNetCore.OpenApi/JsonApiObjects/Links/LinksInResourceIdentifierCollectionDocument.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ internal sealed class LinksInResourceIdentifierCollectionDocument
1818
[JsonPropertyName("describedby")]
1919
public string Describedby { get; set; } = null!;
2020

21-
[Required]
2221
[JsonPropertyName("first")]
2322
public string First { get; set; } = null!;
2423

‎test/OpenApiClientTests/LegacyClient/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3697,7 +3697,6 @@
36973697
},
36983698
"links-in-resource-collection-document": {
36993699
"required": [
3700-
"first",
37013700
"self"
37023701
],
37033702
"type": "object",
@@ -3710,7 +3709,6 @@
37103709
"type": "string"
37113710
},
37123711
"first": {
3713-
"minLength": 1,
37143712
"type": "string"
37153713
},
37163714
"last": {
@@ -3743,7 +3741,6 @@
37433741
},
37443742
"links-in-resource-identifier-collection-document": {
37453743
"required": [
3746-
"first",
37473744
"related",
37483745
"self"
37493746
],
@@ -3761,7 +3758,6 @@
37613758
"type": "string"
37623759
},
37633760
"first": {
3764-
"minLength": 1,
37653761
"type": "string"
37663762
},
37673763
"last": {

‎test/OpenApiClientTests/NamingConventions/CamelCase/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,6 @@
905905
},
906906
"linksInResourceCollectionDocument": {
907907
"required": [
908-
"first",
909908
"self"
910909
],
911910
"type": "object",
@@ -918,7 +917,6 @@
918917
"type": "string"
919918
},
920919
"first": {
921-
"minLength": 1,
922920
"type": "string"
923921
},
924922
"last": {
@@ -951,7 +949,6 @@
951949
},
952950
"linksInResourceIdentifierCollectionDocument": {
953951
"required": [
954-
"first",
955952
"related",
956953
"self"
957954
],
@@ -969,7 +966,6 @@
969966
"type": "string"
970967
},
971968
"first": {
972-
"minLength": 1,
973969
"type": "string"
974970
},
975971
"last": {

‎test/OpenApiClientTests/NamingConventions/KebabCase/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,6 @@
905905
},
906906
"links-in-resource-collection-document": {
907907
"required": [
908-
"first",
909908
"self"
910909
],
911910
"type": "object",
@@ -918,7 +917,6 @@
918917
"type": "string"
919918
},
920919
"first": {
921-
"minLength": 1,
922920
"type": "string"
923921
},
924922
"last": {
@@ -951,7 +949,6 @@
951949
},
952950
"links-in-resource-identifier-collection-document": {
953951
"required": [
954-
"first",
955952
"related",
956953
"self"
957954
],
@@ -969,7 +966,6 @@
969966
"type": "string"
970967
},
971968
"first": {
972-
"minLength": 1,
973969
"type": "string"
974970
},
975971
"last": {

‎test/OpenApiClientTests/NamingConventions/PascalCase/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,6 @@
905905
},
906906
"LinksInResourceCollectionDocument": {
907907
"required": [
908-
"first",
909908
"self"
910909
],
911910
"type": "object",
@@ -918,7 +917,6 @@
918917
"type": "string"
919918
},
920919
"first": {
921-
"minLength": 1,
922920
"type": "string"
923921
},
924922
"last": {
@@ -951,7 +949,6 @@
951949
},
952950
"LinksInResourceIdentifierCollectionDocument": {
953951
"required": [
954-
"first",
955952
"related",
956953
"self"
957954
],
@@ -969,7 +966,6 @@
969966
"type": "string"
970967
},
971968
"first": {
972-
"minLength": 1,
973969
"type": "string"
974970
},
975971
"last": {

‎test/OpenApiClientTests/ResourceFieldValidation/NullableReferenceTypesOff/ModelStateValidationOff/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,6 @@
12881288
},
12891289
"linksInResourceCollectionDocument": {
12901290
"required": [
1291-
"first",
12921291
"self"
12931292
],
12941293
"type": "object",
@@ -1301,7 +1300,6 @@
13011300
"type": "string"
13021301
},
13031302
"first": {
1304-
"minLength": 1,
13051303
"type": "string"
13061304
},
13071305
"last": {
@@ -1334,7 +1332,6 @@
13341332
},
13351333
"linksInResourceIdentifierCollectionDocument": {
13361334
"required": [
1337-
"first",
13381335
"related",
13391336
"self"
13401337
],
@@ -1352,7 +1349,6 @@
13521349
"type": "string"
13531350
},
13541351
"first": {
1355-
"minLength": 1,
13561352
"type": "string"
13571353
},
13581354
"last": {

‎test/OpenApiClientTests/ResourceFieldValidation/NullableReferenceTypesOff/ModelStateValidationOn/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,7 +1344,6 @@
13441344
},
13451345
"linksInResourceCollectionDocument": {
13461346
"required": [
1347-
"first",
13481347
"self"
13491348
],
13501349
"type": "object",
@@ -1357,7 +1356,6 @@
13571356
"type": "string"
13581357
},
13591358
"first": {
1360-
"minLength": 1,
13611359
"type": "string"
13621360
},
13631361
"last": {
@@ -1390,7 +1388,6 @@
13901388
},
13911389
"linksInResourceIdentifierCollectionDocument": {
13921390
"required": [
1393-
"first",
13941391
"related",
13951392
"self"
13961393
],
@@ -1408,7 +1405,6 @@
14081405
"type": "string"
14091406
},
14101407
"first": {
1411-
"minLength": 1,
14121408
"type": "string"
14131409
},
14141410
"last": {

‎test/OpenApiClientTests/ResourceFieldValidation/NullableReferenceTypesOn/ModelStateValidationOff/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,7 +1694,6 @@
16941694
},
16951695
"linksInResourceCollectionDocument": {
16961696
"required": [
1697-
"first",
16981697
"self"
16991698
],
17001699
"type": "object",
@@ -1707,7 +1706,6 @@
17071706
"type": "string"
17081707
},
17091708
"first": {
1710-
"minLength": 1,
17111709
"type": "string"
17121710
},
17131711
"last": {
@@ -1740,7 +1738,6 @@
17401738
},
17411739
"linksInResourceIdentifierCollectionDocument": {
17421740
"required": [
1743-
"first",
17441741
"related",
17451742
"self"
17461743
],
@@ -1758,7 +1755,6 @@
17581755
"type": "string"
17591756
},
17601757
"first": {
1761-
"minLength": 1,
17621758
"type": "string"
17631759
},
17641760
"last": {

‎test/OpenApiClientTests/ResourceFieldValidation/NullableReferenceTypesOn/ModelStateValidationOn/swagger.g.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,7 +1694,6 @@
16941694
},
16951695
"linksInResourceCollectionDocument": {
16961696
"required": [
1697-
"first",
16981697
"self"
16991698
],
17001699
"type": "object",
@@ -1707,7 +1706,6 @@
17071706
"type": "string"
17081707
},
17091708
"first": {
1710-
"minLength": 1,
17111709
"type": "string"
17121710
},
17131711
"last": {
@@ -1740,7 +1738,6 @@
17401738
},
17411739
"linksInResourceIdentifierCollectionDocument": {
17421740
"required": [
1743-
"first",
17441741
"related",
17451742
"self"
17461743
],
@@ -1758,7 +1755,6 @@
17581755
"type": "string"
17591756
},
17601757
"first": {
1761-
"minLength": 1,
17621758
"type": "string"
17631759
},
17641760
"last": {

‎test/OpenApiTests/LegacyOpenApiIntegration/swagger.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3697,7 +3697,6 @@
36973697
},
36983698
"links-in-resource-collection-document": {
36993699
"required": [
3700-
"first",
37013700
"self"
37023701
],
37033702
"type": "object",
@@ -3710,7 +3709,6 @@
37103709
"type": "string"
37113710
},
37123711
"first": {
3713-
"minLength": 1,
37143712
"type": "string"
37153713
},
37163714
"last": {
@@ -3743,7 +3741,6 @@
37433741
},
37443742
"links-in-resource-identifier-collection-document": {
37453743
"required": [
3746-
"first",
37473744
"related",
37483745
"self"
37493746
],
@@ -3761,7 +3758,6 @@
37613758
"type": "string"
37623759
},
37633760
"first": {
3764-
"minLength": 1,
37653761
"type": "string"
37663762
},
37673763
"last": {

0 commit comments

Comments
 (0)