Refactored tests for non-json:api controllers

Author: Bart Koelman

src/Examples/JsonApiDotNetCoreExample/Controllers/NonJsonApiController.cs

@@ -0,0 +1,51 @@
+using System.IO;
+using System.Threading.Tasks;
+using Microsoft.AspNetCore.Mvc;
+
+namespace JsonApiDotNetCoreExample.Controllers
+{
+    [Route("[controller]")]
+    public sealed class NonJsonApiController : ControllerBase
+    {
+        [HttpGet]
+        public IActionResult Get()
+        {
+            var result = new[] {"Welcome!"};
+            return Ok(result);
+        }
+
+        [HttpPost]
+        public async Task<IActionResult> PostAsync()
+        {
+            string name = await new StreamReader(Request.Body).ReadToEndAsync();
+
+            if (string.IsNullOrEmpty(name))
+            {
+                return BadRequest("Please send your name.");
+            }
+
+            var result = "Hello, " + name;
+            return Ok(result);
+        }
+
+        [HttpPut]
+        public IActionResult Put([FromBody] string name)
+        {
+            var result = "Hi, " + name;
+            return Ok(result);
+        }
+
+        [HttpPatch]
+        public IActionResult Patch(string name)
+        {
+            var result = "Good day, " + name;
+            return Ok(result);
+        }
+
+        [HttpDelete]
+        public IActionResult Delete()
+        {
+            return Ok("Bye.");
+        }
+    }
+}

src/Examples/JsonApiDotNetCoreExample/Controllers/TestValuesController.cs

@@ -37,26 +37,6 @@ public CustomControllerTests(TestFixture<TestStartup> fixture)
                 .RuleFor(p => p.LastName, f => f.Name.LastName());
         }
 
-        [Fact]
-        public async Task NonJsonApiControllers_DoNotUse_Dasherized_Routes()
-        {
-            // Arrange
-            var builder = WebHost.CreateDefaultBuilder()
-                .UseStartup<TestStartup>();
-            var httpMethod = new HttpMethod("GET");
-            var route = "testValues";
-
-            var server = new TestServer(builder);
-            var client = server.CreateClient();
-            var request = new HttpRequestMessage(httpMethod, route);
-
-            // Act
-            var response = await client.SendAsync(request);
-
-            // Assert
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-        }
-
         [Fact]
         public async Task CustomRouteControllers_Uses_Dasherized_Collection_Route()
         {

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/CustomControllerTests.cs

@@ -0,0 +1,153 @@
+using System.Net;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using System.Threading.Tasks;
+using FluentAssertions;
+using JsonApiDotNetCoreExample;
+using Microsoft.AspNetCore.Mvc.Testing;
+using Xunit;
+
+namespace JsonApiDotNetCoreExampleTests.IntegrationTests.NonJsonApiControllers
+{
+    public sealed class NonJsonApiControllerTests : IClassFixture<WebApplicationFactory<Startup>>
+    {
+        private readonly WebApplicationFactory<Startup> _factory;
+
+        public NonJsonApiControllerTests(WebApplicationFactory<Startup> factory)
+        {
+            _factory = factory;
+        }
+
+        [Fact]
+        public async Task Get_skips_middleware_and_formatters()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Get, "/NonJsonApi");
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("application/json; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("[\"Welcome!\"]");
+        }
+
+        [Fact]
+        public async Task Post_skips_middleware_and_formatters()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Post, "/NonJsonApi")
+            {
+                Content = new StringContent("Jack")
+                {
+                    Headers =
+                    {
+                        ContentType = new MediaTypeHeaderValue("text/plain")
+                    }
+                }
+            };
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("text/plain; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("Hello, Jack");
+        }
+
+        [Fact]
+        public async Task Post_skips_error_handler()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Post, "/NonJsonApi");
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.BadRequest);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("text/plain; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("Please send your name.");
+        }
+
+        [Fact]
+        public async Task Put_skips_middleware_and_formatters()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Put, "/NonJsonApi")
+            {
+                Content = new StringContent("\"Jane\"")
+                {
+                    Headers =
+                    {
+                        ContentType = new MediaTypeHeaderValue("application/json")
+                    }
+                }
+            };
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("text/plain; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("Hi, Jane");
+        }
+
+        [Fact]
+        public async Task Patch_skips_middleware_and_formatters()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Patch, "/NonJsonApi?name=Janice");
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("text/plain; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("Good day, Janice");
+        }
+
+        [Fact]
+        public async Task Delete_skips_middleware_and_formatters()
+        {
+            // Arrange
+            var request = new HttpRequestMessage(HttpMethod.Delete, "/NonJsonApi");
+
+            var client = _factory.CreateClient();
+
+            // Act
+            var httpResponse = await client.SendAsync(request);
+
+            // Assert
+            httpResponse.Should().HaveStatusCode(HttpStatusCode.OK);
+            httpResponse.Content.Headers.ContentType.ToString().Should().Be("text/plain; charset=utf-8");
+
+            string responseText = await httpResponse.Content.ReadAsStringAsync();
+            responseText.Should().Be("Bye.");
+        }
+    }
+}