Skip to content

Commit 2ad702c

Browse files
committed
Review feedback
1 parent 45a0672 commit 2ad702c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/FilterParseTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ public void Reader_Read_Fails(string parameterName, string parameterValue, strin
115115
[InlineData("filter", "equals(title,'Brian O''Quote')", null, "equals(title,'Brian O''Quote')")]
116116
[InlineData("filter", "equals(title,'!@#$%^&*()-_=+\"''[]{}<>()/|\\:;.,`~')", null, "equals(title,'!@#$%^&*()-_=+\"''[]{}<>()/|\\:;.,`~')")]
117117
[InlineData("filter", "equals(title,'')", null, "equals(title,'')")]
118-
[InlineData("filter", "startsWith(name,'GivenName ')", null, "startsWith(name,'GivenName ')")]
119-
[InlineData("filter", "endsWith(name,' Surname')", null, "endsWith(name,' Surname')")]
120-
[InlineData("filter", "contains(name,' ')", null, "contains(name,' ')")]
118+
[InlineData("filter", "startsWith(owner.displayName,'GivenName ')", null, "startsWith(owner.displayName,'GivenName ')")]
119+
[InlineData("filter", "endsWith(owner.displayName,' Surname')", null, "endsWith(owner.displayName,' Surname')")]
120+
[InlineData("filter", "contains(owner.displayName,' ')", null, "contains(owner.displayName,' ')")]
121121
[InlineData("filter[posts]", "equals(caption,'this, that & more')", "posts", "equals(caption,'this, that & more')")]
122122
[InlineData("filter[owner.posts]", "equals(caption,'some')", "owner.posts", "equals(caption,'some')")]
123123
[InlineData("filter[posts.comments]", "equals(createdAt,'2000-01-01')", "posts.comments", "equals(createdAt,'2000-01-01')")]

test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/LegacyFilterParseTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ public void Reader_Read_Fails(string parameterName, string parameterValue, strin
7474
[InlineData("filter[caption]", "isnull:", "equals(caption,null)")]
7575
[InlineData("filter[caption]", "isnotnull:", "not(equals(caption,null))")]
7676
[InlineData("filter[caption]", "unknown:some", "equals(caption,'unknown:some')")]
77+
[InlineData("filter[caption]", " ", "equals(caption,' ')")]
7778
[InlineData("filter[author.userName]", "Jack", "equals(author.userName,'Jack')")]
7879
[InlineData("filter", "expr:equals(caption,'some')", "equals(caption,'some')")]
79-
[InlineData("filter", "expr:equals(caption,' ')", "equals(caption,' ')")]
8080
[InlineData("filter", "expr:equals(author,null)", "equals(author,null)")]
8181
[InlineData("filter", "expr:has(author.posts)", "has(author.posts)")]
8282
[InlineData("filter", "expr:equals(count(author.posts),'1')", "equals(count(author.posts),'1')")]

0 commit comments

Comments
 (0)