Further reduce tests verbosity

btecu · btecu · commit 21033446867a · 2018-06-13T17:57:21.000-04:00
diff --git a/src/Examples/JsonApiDotNetCoreExample/Startup.cs b/src/Examples/JsonApiDotNetCoreExample/Startup.cs
@@ -28,7 +28,7 @@ public Startup(IHostingEnvironment env)
         public virtual IServiceProvider ConfigureServices(IServiceCollection services)
         {
             var loggerFactory = new LoggerFactory();
-            loggerFactory.AddConsole(LogLevel.Trace);
+            loggerFactory.AddConsole(LogLevel.Warning);
 
             services
                 .AddSingleton<ILoggerFactory>(loggerFactory)
@@ -57,7 +57,6 @@ public virtual void Configure(
             context.Database.EnsureCreated();
 
             loggerFactory.AddConsole(Config.GetSection("Logging"));
-            loggerFactory.AddDebug();
 
             app.UseJsonApi();
         }
diff --git a/src/Examples/NoEntityFrameworkExample/Startup.cs b/src/Examples/NoEntityFrameworkExample/Startup.cs
@@ -1,4 +1,4 @@
-﻿using JsonApiDotNetCore.Extensions;
+using JsonApiDotNetCore.Extensions;
 using JsonApiDotNetCore.Services;
 using JsonApiDotNetCoreExample.Data;
 using JsonApiDotNetCoreExample.Models;
@@ -55,7 +55,6 @@ public virtual IServiceProvider ConfigureServices(IServiceCollection services)
         public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory, AppDbContext context)
         {
             loggerFactory.AddConsole(Configuration.GetSection("Logging"));
-            loggerFactory.AddDebug();
 
             context.Database.EnsureCreated();
 
diff --git a/src/Examples/OperationsExample/Startup.cs b/src/Examples/OperationsExample/Startup.cs
@@ -27,7 +27,7 @@ public Startup(IHostingEnvironment env)
         public virtual IServiceProvider ConfigureServices(IServiceCollection services)
         {
             var loggerFactory = new LoggerFactory();
-            loggerFactory.AddConsole(LogLevel.Trace);
+            loggerFactory.AddConsole(LogLevel.Warning);
 
             services.AddSingleton<ILoggerFactory>(loggerFactory);
 
@@ -47,7 +47,6 @@ public virtual void Configure(
             context.Database.EnsureCreated();
 
             loggerFactory.AddConsole(Config.GetSection("Logging"));
-            loggerFactory.AddDebug();
             app.UseJsonApi();
         }
 
diff --git a/src/Examples/ReportsExample/appsettings.json b/src/Examples/ReportsExample/appsettings.json
@@ -2,7 +2,7 @@
   "Logging": {
     "IncludeScopes": false,
     "LogLevel": {
-      "Default": "Information"
+      "Default": "Warning"
     }
   }
 }
diff --git a/src/JsonApiDotNetCore/Serialization/JsonApiSerializer.cs b/src/JsonApiDotNetCore/Serialization/JsonApiSerializer.cs
@@ -65,7 +65,11 @@ private string GetErrorJson(object responseObject, ILogger logger)
             }
             else
             {
-                logger?.LogInformation("Response was not a JSONAPI entity. Serializing as plain JSON.");
+                if (logger?.IsEnabled(LogLevel.Information) == true)
+                {
+                    logger.LogInformation("Response was not a JSONAPI entity. Serializing as plain JSON.");
+                }
+                
                 return JsonConvert.SerializeObject(responseObject);
             }
         }
diff --git a/src/JsonApiDotNetCore/Services/EntityResourceService.cs b/src/JsonApiDotNetCore/Services/EntityResourceService.cs
@@ -89,8 +89,10 @@ public virtual async Task<object> GetRelationshipAsync(TId id, string relationsh
 
             if (relationshipName == null)
                 throw new JsonApiException(422, "Relationship name not specified.");
-
-            _logger.LogTrace($"Looking up '{relationshipName}'...");
+            if (_logger.IsEnabled(LogLevel.Trace))
+            {
+                _logger.LogTrace($"Looking up '{relationshipName}'...");
+            }
 
             var entity = await _entities.GetAndIncludeAsync(id, relationshipName);
             // TODO: it would be better if we could distinguish whether or not the relationship was not found,
@@ -166,7 +168,10 @@ protected virtual async Task<IEnumerable<T>> ApplyPageQueryAsync(IQueryable<T> e
             if (!pageManager.IsPaginated)
                 return await _entities.ToListAsync(entities);
 
-            _logger?.LogInformation($"Applying paging query. Fetching page {pageManager.CurrentPage} with {pageManager.PageSize} entities");
+            if (_logger?.IsEnabled(LogLevel.Information) == true)
+            {
+                _logger?.LogInformation($"Applying paging query. Fetching page {pageManager.CurrentPage} with {pageManager.PageSize} entities");
+            }
 
             return await _entities.PageAsync(entities, pageManager.PageSize, pageManager.CurrentPage);
         }
diff --git a/src/JsonApiDotNetCore/Services/QueryAccessor.cs b/src/JsonApiDotNetCore/Services/QueryAccessor.cs
@@ -45,7 +45,11 @@ public bool TryGetValue<T>(string key, out T value)
             var stringValue = GetFilterValue(key);
             if (stringValue == null)
             {
-                _logger.LogInformation($"'{key}' was not found in the query collection");
+                if (_logger.IsEnabled(LogLevel.Information))
+                {
+                    _logger.LogInformation($"'{key}' was not found in the query collection");
+                }
+
                 return false;
             }
 
@@ -56,7 +60,12 @@ public bool TryGetValue<T>(string key, out T value)
             }
             catch (FormatException)
             {
-                _logger.LogInformation($"'{value}' is not a valid '{typeof(T).Name}' value for query parameter {key}");
+                if (_logger.IsEnabled(LogLevel.Information))
+                {
+                    _logger.LogInformation(
+                        $"'{value}' is not a valid '{typeof(T).Name}' value for query parameter {key}");
+                }
+
                 return false;
             }
         }
diff --git a/test/JsonApiDotNetCoreExampleTests/Helpers/Startups/MetaStartup.cs b/test/JsonApiDotNetCoreExampleTests/Helpers/Startups/MetaStartup.cs
@@ -20,7 +20,7 @@ public MetaStartup(IHostingEnvironment env)
         public override IServiceProvider ConfigureServices(IServiceCollection services)
         {
             var loggerFactory = new LoggerFactory();
-            loggerFactory.AddConsole(LogLevel.Trace);
+            loggerFactory.AddConsole(LogLevel.Warning);
 
             services
                 .AddSingleton<ILoggerFactory>(loggerFactory)
diff --git a/test/JsonApiDotNetCoreExampleTests/appsettings.json b/test/JsonApiDotNetCoreExampleTests/appsettings.json
@@ -5,9 +5,9 @@
     "Logging": {
         "IncludeScopes": false,
         "LogLevel": {
-            "Default": "Error",
-            "System": "Information",
-            "Microsoft": "Information"
+            "Default": "Warning",
+            "System": "Warning",
+            "Microsoft": "Warning"
         }
     }
 }
diff --git a/test/NoEntityFrameworkTests/appsettings.json b/test/NoEntityFrameworkTests/appsettings.json
@@ -5,9 +5,9 @@
     "Logging": {
         "IncludeScopes": false,
         "LogLevel": {
-            "Default": "Debug",
-            "System": "Information",
-            "Microsoft": "Information"
+            "Default": "Warning",
+            "System": "Warning",
+            "Microsoft": "Warning"
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public Startup(IHostingEnvironment env)`
`28`	`28`	`public virtual IServiceProvider ConfigureServices(IServiceCollection services)`
`29`	`29`	`{`
`30`	`30`	`var loggerFactory = new LoggerFactory();`
`31`		`- loggerFactory.AddConsole(LogLevel.Trace);`
	`31`	`+ loggerFactory.AddConsole(LogLevel.Warning);`
`32`	`32`
`33`	`33`	`services`
`34`	`34`	`.AddSingleton<ILoggerFactory>(loggerFactory)`
`@@ -57,7 +57,6 @@ public virtual void Configure(`
`57`	`57`	`context.Database.EnsureCreated();`
`58`	`58`
`59`	`59`	`loggerFactory.AddConsole(Config.GetSection("Logging"));`
`60`		`- loggerFactory.AddDebug();`
`61`	`60`
`62`	`61`	`app.UseJsonApi();`
`63`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public Startup(IHostingEnvironment env)`
`27`	`27`	`public virtual IServiceProvider ConfigureServices(IServiceCollection services)`
`28`	`28`	`{`
`29`	`29`	`var loggerFactory = new LoggerFactory();`
`30`		`- loggerFactory.AddConsole(LogLevel.Trace);`
	`30`	`+ loggerFactory.AddConsole(LogLevel.Warning);`
`31`	`31`
`32`	`32`	`services.AddSingleton<ILoggerFactory>(loggerFactory);`
`33`	`33`
`@@ -47,7 +47,6 @@ public virtual void Configure(`
`47`	`47`	`context.Database.EnsureCreated();`
`48`	`48`
`49`	`49`	`loggerFactory.AddConsole(Config.GetSection("Logging"));`
`50`		`- loggerFactory.AddDebug();`
`51`	`50`	`app.UseJsonApi();`
`52`	`51`	`}`
`53`	`52`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`"Logging": {`
`3`	`3`	`"IncludeScopes": false,`
`4`	`4`	`"LogLevel": {`
`5`		`- "Default": "Information"`
	`5`	`+ "Default": "Warning"`
`6`	`6`	`}`
`7`	`7`	`}`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,11 @@ private string GetErrorJson(object responseObject, ILogger logger)`
`65`	`65`	`}`
`66`	`66`	`else`
`67`	`67`	`{`
`68`		`- logger?.LogInformation("Response was not a JSONAPI entity. Serializing as plain JSON.");`
	`68`	`+ if (logger?.IsEnabled(LogLevel.Information) == true)`
	`69`	`+ {`
	`70`	`+ logger.LogInformation("Response was not a JSONAPI entity. Serializing as plain JSON.");`
	`71`	`+ }`
	`72`	`+`
`69`	`73`	`return JsonConvert.SerializeObject(responseObject);`
`70`	`74`	`}`
`71`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,11 @@ public bool TryGetValue<T>(string key, out T value)`
`45`	`45`	`var stringValue = GetFilterValue(key);`
`46`	`46`	`if (stringValue == null)`
`47`	`47`	`{`
`48`		`- _logger.LogInformation($"'{key}' was not found in the query collection");`
	`48`	`+ if (_logger.IsEnabled(LogLevel.Information))`
	`49`	`+ {`
	`50`	`+ _logger.LogInformation($"'{key}' was not found in the query collection");`
	`51`	`+ }`
	`52`	`+`
`49`	`53`	`return false;`
`50`	`54`	`}`
`51`	`55`
`@@ -56,7 +60,12 @@ public bool TryGetValue<T>(string key, out T value)`
`56`	`60`	`}`
`57`	`61`	`catch (FormatException)`
`58`	`62`	`{`
`59`		`- _logger.LogInformation($"'{value}' is not a valid '{typeof(T).Name}' value for query parameter {key}");`
	`63`	`+ if (_logger.IsEnabled(LogLevel.Information))`
	`64`	`+ {`
	`65`	`+ _logger.LogInformation(`
	`66`	`+ $"'{value}' is not a valid '{typeof(T).Name}' value for query parameter {key}");`
	`67`	`+ }`
	`68`	`+`
`60`	`69`	`return false;`
`61`	`70`	`}`
`62`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public MetaStartup(IHostingEnvironment env)`
`20`	`20`	`public override IServiceProvider ConfigureServices(IServiceCollection services)`
`21`	`21`	`{`
`22`	`22`	`var loggerFactory = new LoggerFactory();`
`23`		`- loggerFactory.AddConsole(LogLevel.Trace);`
	`23`	`+ loggerFactory.AddConsole(LogLevel.Warning);`
`24`	`24`
`25`	`25`	`services`
`26`	`26`	`.AddSingleton<ILoggerFactory>(loggerFactory)`
Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,9 @@`
`5`	`5`	`"Logging": {`
`6`	`6`	`"IncludeScopes": false,`
`7`	`7`	`"LogLevel": {`
`8`		`- "Default": "Error",`
`9`		`- "System": "Information",`
`10`		`- "Microsoft": "Information"`
	`8`	`+ "Default": "Warning",`
	`9`	`+ "System": "Warning",`
	`10`	`+ "Microsoft": "Warning"`
`11`	`11`	`}`
`12`	`12`	`}`
`13`	`13`	`}`