Added test to capture the current behavior to return data:null for void operations. The spec allows an empty object too, but I don't consider this important enough to add yet another JSON converter with all its overhead.

Author: Bart Koelman

test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicSerializationTests.cs

@@ -4,7 +4,6 @@
 using System.Threading.Tasks;
 using FluentAssertions;
 using JsonApiDotNetCore.Configuration;
-using JsonApiDotNetCore.Resources;
 using Microsoft.Extensions.DependencyInjection;
 using TestBuildingBlocks;
 using Xunit;
@@ -13,8 +12,6 @@ namespace JsonApiDotNetCoreTests.IntegrationTests.AtomicOperations.Mixed
 {
     public sealed class AtomicSerializationTests : IClassFixture<IntegrationTestContext<TestableStartup<OperationsDbContext>, OperationsDbContext>>
     {
-        private const string JsonDateTimeOffsetFormatSpecifier = "yyyy-MM-ddTHH:mm:ss.FFFFFFFK";
-
         private readonly IntegrationTestContext<TestableStartup<OperationsDbContext>, OperationsDbContext> _testContext;
         private readonly OperationsFakers _fakers = new();
 
@@ -25,11 +22,11 @@ public AtomicSerializationTests(IntegrationTestContext<TestableStartup<Operation
             testContext.UseController<OperationsController>();
 
             // These routes need to be registered in ASP.NET for rendering links to resource/relationship endpoints.
-            testContext.UseController<PerformersController>();
+            testContext.UseController<TextLanguagesController>();
 
             testContext.ConfigureServicesAfterStartup(services =>
             {
-                services.AddScoped(typeof(IResourceChangeTracker<>), typeof(NeverSameResourceChangeTracker<>));
+                services.AddResourceDefinition<ImplicitlyChangingTextLanguageDefinition>();
             });
 
             var options = (JsonApiOptions)testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
@@ -39,32 +36,46 @@ public AtomicSerializationTests(IntegrationTestContext<TestableStartup<Operation
         }
 
         [Fact]
-        public async Task Includes_version_with_ext_on_operations_endpoint()
+        public async Task Hides_data_for_void_operation()
         {
             // Arrange
-            Performer newPerformer = _fakers.Performer.Generate();
-            newPerformer.Id = Unknown.TypedId.Int32;
+            Performer existingPerformer = _fakers.Performer.Generate();
+
+            TextLanguage newLanguage = _fakers.TextLanguage.Generate();
+            newLanguage.Id = Guid.NewGuid();
 
             await _testContext.RunOnDatabaseAsync(async dbContext =>
             {
-                await dbContext.ClearTableAsync<Performer>();
+                dbContext.Performers.Add(existingPerformer);
+                await dbContext.SaveChangesAsync();
             });
 
             var requestBody = new
             {
-                atomic__operations = new[]
+                atomic__operations = new object[]
                 {
                     new
                     {
-                        op = "add",
+                        op = "update",
                         data = new
                         {
                             type = "performers",
-                            id = newPerformer.StringId,
+                            id = existingPerformer.StringId,
                             attributes = new
                             {
-                                artistName = newPerformer.ArtistName,
-                                bornAt = newPerformer.BornAt
+                            }
+                        }
+                    },
+                    new
+                    {
+                        op = "add",
+                        data = new
+                        {
+                            type = "textLanguages",
+                            id = newLanguage.StringId,
+                            attributes = new
+                            {
+                                isoCode = newLanguage.IsoCode
                             }
                         }
                     }
@@ -87,16 +98,26 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
     ]
   },
   ""atomic:results"": [
+    {
+      ""data"": null
+    },
     {
       ""data"": {
-        ""type"": ""performers"",
-        ""id"": """ + newPerformer.StringId + @""",
+        ""type"": ""textLanguages"",
+        ""id"": """ + newLanguage.StringId + @""",
         ""attributes"": {
-          ""artistName"": """ + newPerformer.ArtistName + @""",
-          ""bornAt"": """ + newPerformer.BornAt.ToString(JsonDateTimeOffsetFormatSpecifier) + @"""
+          ""isoCode"": """ + newLanguage.IsoCode + @" (changed)""
+        },
+        ""relationships"": {
+          ""lyrics"": {
+            ""links"": {
+              ""self"": ""http://localhost/textLanguages/" + newLanguage.StringId + @"/relationships/lyrics"",
+              ""related"": ""http://localhost/textLanguages/" + newLanguage.StringId + @"/lyrics""
+            }
+          }
         },
         ""links"": {
-          ""self"": ""http://localhost/performers/" + newPerformer.StringId + @"""
+          ""self"": ""http://localhost/textLanguages/" + newLanguage.StringId + @"""
         }
       }
     }