Fixed: crash in test serializer on assertion failure

Bart Koelman · Bart Koelman · commit 107a3e744c68 · 2021-10-06T15:14:36.000+02:00
diff --git a/test/TestBuildingBlocks/HttpResponseMessageExtensions.cs b/test/TestBuildingBlocks/HttpResponseMessageExtensions.cs
@@ -30,7 +30,7 @@ public AndConstraint<HttpResponseMessageAssertions> HaveStatusCode(HttpStatusCod
                 if (Subject.StatusCode != statusCode)
                 {
                     string responseText = Subject.Content.ReadAsStringAsync().Result;
-                    Subject.StatusCode.Should().Be(statusCode, $"response body returned was:\n{responseText}");
+                    Subject.StatusCode.Should().Be(statusCode, string.IsNullOrEmpty(responseText) ? null : $"response body returned was:\n{responseText}");
                 }
 
                 return new AndConstraint<HttpResponseMessageAssertions>(this);
diff --git a/test/TestBuildingBlocks/IntegrationTest.cs b/test/TestBuildingBlocks/IntegrationTest.cs
@@ -95,6 +95,11 @@ private TResponseDocument DeserializeResponse<TResponseDocument>(string response
                 return (TResponseDocument)(object)responseText;
             }
 
+            if (string.IsNullOrEmpty(responseText))
+            {
+                return default;
+            }
+
             try
             {
                 return JsonSerializer.Deserialize<TResponseDocument>(responseText, SerializerOptions);

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public AndConstraint<HttpResponseMessageAssertions> HaveStatusCode(HttpStatusCod`
`30`	`30`	`if (Subject.StatusCode != statusCode)`
`31`	`31`	`{`
`32`	`32`	`string responseText = Subject.Content.ReadAsStringAsync().Result;`
`33`		`- Subject.StatusCode.Should().Be(statusCode, $"response body returned was:\n{responseText}");`
	`33`	`+ Subject.StatusCode.Should().Be(statusCode, string.IsNullOrEmpty(responseText) ? null : $"response body returned was:\n{responseText}");`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`return new AndConstraint<HttpResponseMessageAssertions>(this);`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,11 @@ private TResponseDocument DeserializeResponse<TResponseDocument>(string response`
`95`	`95`	`return (TResponseDocument)(object)responseText;`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ if (string.IsNullOrEmpty(responseText))`
	`99`	`+ {`
	`100`	`+ return default;`
	`101`	`+ }`
	`102`	`+`
`98`	`103`	`try`
`99`	`104`	`{`
`100`	`105`	`return JsonSerializer.Deserialize<TResponseDocument>(responseText, SerializerOptions);`