Review feedback: move exception to client tool, restore constraint on argument guard method, rename swagger documents, fix assembly path in LegacyOpenApiIntegrationTests.

Author: maurei

test/OpenApiClientTests/ApiException.cs renamed to src/JsonApiDotNetCore.OpenApi.Client/ApiException.cs

@@ -24,7 +24,7 @@ public LegacyOpenApiIntegrationTests()
         public async Task Retrieved_document_matches_expected_document()
         {
             // Arrange
-            string embeddedResourceName = $"{nameof(OpenApiTests)}.SwaggerDocuments.{nameof(LegacyOpenApiIntegration)}.json";
+            string embeddedResourceName = $"{nameof(OpenApiTests)}.{nameof(LegacyOpenApiIntegration)}.swagger.json";
             string expectedDocument = await LoadEmbeddedResourceAsync(embeddedResourceName);
             const string requestUrl = "swagger/v1/swagger.json";
 

test/OpenApiTests/LegacyOpenApiIntegration/LegacyOpenApiIntegrationTests.cs

@@ -17,7 +17,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <EmbeddedResource Include="LegacyOpenApiIntegration\LegacyOpenApiIntegration.json"/>
+        <EmbeddedResource Include="LegacyOpenApiIntegration\swagger.json"/>
     </ItemGroup>
 
     <!-- Fixes IntelliSense errors on openapi.json in Visual Studio 2019, which uses the schema for OpenAPI 3.1 by default. -->