introduce IEntityFrameworkRepository and bump version

allows changes to be rolled out in a non-breaking way

Author: jaredcnance

src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs

@@ -32,7 +32,8 @@ public DefaultEntityRepository(
     /// abstracting any EF Core APIs away from the service layer.
     /// </summary>
     public class DefaultEntityRepository<TEntity, TId>
-        : IEntityRepository<TEntity, TId>
+        : IEntityRepository<TEntity, TId>,
+        IEntityFrameworkRepository<TEntity>
         where TEntity : class, IIdentifiable<TId>
     {
         private readonly DbContext _context;

src/JsonApiDotNetCore/Data/IEntityRepository.cs

@@ -12,4 +12,25 @@ public interface IEntityRepository<TEntity, in TId>
         IEntityWriteRepository<TEntity, TId>
         where TEntity : class, IIdentifiable<TId>
     { }
+
+    /// <summary>
+    /// A staging interface to avoid breaking changes that 
+    /// specifically depend on EntityFramework.
+    /// </summary>
+    internal interface IEntityFrameworkRepository<TEntity>
+    {
+        /// <summary>
+        /// Ensures that any relationship pointers created during a POST or PATCH
+        /// request are detached from the DbContext.
+        /// This allows the relationships to be fully loaded from the database.
+        /// 
+        /// </summary>
+        /// <remarks>
+        /// The only known case when this should be called is when a POST request is
+        /// sent with an ?include query.
+        /// 
+        /// See https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/343
+        /// </remarks>
+        void DetachRelationshipPointers(TEntity entity);
+    }
 }

src/JsonApiDotNetCore/Data/IEntityWriteRepository.cs

@@ -19,19 +19,5 @@ public interface IEntityWriteRepository<TEntity, in TId>
         Task UpdateRelationshipsAsync(object parent, RelationshipAttribute relationship, IEnumerable<string> relationshipIds);
 
         Task<bool> DeleteAsync(TId id);
-
-        /// <summary>
-        /// Ensures that any relationship pointers created during a POST or PATCH
-        /// request are detached from the DbContext.
-        /// This allows the relationships to be fully loaded from the database.
-        /// 
-        /// </summary>
-        /// <remarks>
-        /// The only known case when this should be called is when a POST request is
-        /// sent with an ?include query.
-        /// 
-        /// See https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/343
-        /// </remarks>
-        void DetachRelationshipPointers(TEntity entity);
     }
 }

src/JsonApiDotNetCore/JsonApiDotNetCore.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <VersionPrefix>2.5.0</VersionPrefix>
+    <VersionPrefix>2.5.1</VersionPrefix>
     <TargetFrameworks>$(NetStandardVersion)</TargetFrameworks>
     <AssemblyName>JsonApiDotNetCore</AssemblyName>
     <PackageId>JsonApiDotNetCore</PackageId>

src/JsonApiDotNetCore/Services/EntityResourceService.cs

@@ -82,7 +82,9 @@ public virtual async Task<TResource> CreateAsync(TResource resource)
             // https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/343
             if (ShouldIncludeRelationships())
             {
-                _entities.DetachRelationshipPointers(entity);
+                if(_entities is IEntityFrameworkRepository<TEntity> efRepository)
+                    efRepository.DetachRelationshipPointers(entity);
+
                 return await GetWithRelationshipsAsync(entity.Id);
             }