Merge pull request #523 from ngboardway/master

Fix/#522

Author: maurei

src/JsonApiDotNetCore/Internal/TypeHelper.cs

@@ -40,6 +40,9 @@ public static object ConvertType(object value, Type type)
                 if (type == typeof(DateTimeOffset))
                     return DateTimeOffset.Parse(stringValue);
 
+                if(type == typeof(TimeSpan)) 
+                    return TimeSpan.Parse(stringValue);
+
                 if (type.GetTypeInfo().IsEnum)
                     return Enum.Parse(type, stringValue);
 

test/UnitTests/Internal/TypeHelper_Tests.cs

@@ -106,6 +106,30 @@ public void ConvertType_Returns_Default_Value_For_Empty_Strings()
                 Assert.Equal(t.Value, result);
             }
         }
+        
+        [Fact]
+        public void Can_Convert_TimeSpans() 
+        {
+            //arrange
+            TimeSpan timeSpan = TimeSpan.FromMinutes(45);
+            string stringSpan = timeSpan.ToString();
+
+            //act
+            var result = TypeHelper.ConvertType(stringSpan, typeof(TimeSpan));
+
+            //assert
+            Assert.Equal(timeSpan, result);
+        }
+
+        [Fact]
+        public void Bad_TimeSpanString_Throws() 
+        {
+            // arrange
+            var formattedString = "this_is_not_a_valid_timespan";
+
+            // act/assert
+            Assert.Throws<FormatException>(() => TypeHelper.ConvertType(formattedString, typeof(TimeSpan)));
+        }
 
         private enum TestEnum
         {