Skip to content

Commit 784c88a

Browse files
authored
fix: initial disabled controller state (#210) (#211)
1 parent cc95a1b commit 784c88a

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

src/components/ParallaxProvider/index.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ describe('A <ParallaxProvider>', () => {
6868

6969
expect(
7070
// @ts-expect-error
71-
parallaxController.disableParallaxController
72-
).toBeCalled();
71+
parallaxController.disabled
72+
).toBe(true);
7373

7474
context.rerender(
7575
<ParallaxProvider>

src/components/ParallaxProvider/index.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,10 @@ export class ParallaxProvider extends Component<ParallaxProviderProps, {}> {
1717
this.controller = createController({
1818
scrollAxis: props.scrollAxis,
1919
scrollContainer: props.scrollContainer,
20+
disabled: props.isDisabled,
2021
});
2122
}
2223

23-
componentDidMount() {
24-
if (this.props.isDisabled) {
25-
this.controller?.disableParallaxController();
26-
}
27-
}
28-
2924
componentDidUpdate(prevProps: ParallaxProviderProps) {
3025
if (
3126
prevProps.scrollContainer !== this.props.scrollContainer &&

0 commit comments

Comments
 (0)