Skip to content

Commit eb5374a

Browse files
committed
Menu: Remove redundant handling of disabled option on create
Ref #9151
1 parent 337b307 commit eb5374a

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

ui/widgets/menu.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,6 @@ return $.widget( "ui.menu", {
7171
tabIndex: 0
7272
} );
7373

74-
if ( this.options.disabled ) {
75-
this._addClass( null, "ui-state-disabled" );
76-
this.element.attr( "aria-disabled", "true" );
77-
}
78-
7974
this._addClass( "ui-menu", "ui-widget ui-widget-content" );
8075
this._on( {
8176

@@ -360,12 +355,18 @@ return $.widget( "ui.menu", {
360355
._addClass( icons, null, value.submenu );
361356
}
362357
if ( key === "disabled" ) {
363-
this.element.attr( "aria-disabled", value );
364-
this._toggleClass( null, "ui-state-disabled", !!value );
358+
this._setOptionDisabled( value );
365359
}
366360
this._super( key, value );
367361
},
368362

363+
_setOptionDisabled: function( value ) {
364+
this._super( value );
365+
366+
this.element.attr( "aria-disabled", String( value ) );
367+
this._toggleClass( null, "ui-state-disabled", !!value );
368+
},
369+
369370
focus: function( event, item ) {
370371
var nested, focused, activeParent;
371372
this.blur( event, event && event.type === "focus" );

0 commit comments

Comments
 (0)