Skip to content

Commit b33f8a5

Browse files
committed
Effects: Allow all "effect" calls to default to default Mode.
This fixes the situation where calling e.g. .effect("highlight") was a no-op as if .show("highlight") was called.
1 parent 38d6b5d commit b33f8a5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ui/effect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,7 +1260,7 @@ $.fn.extend({
12601260
effectPrefilter = function() {
12611261

12621262
var el = $( this ),
1263-
normalizedMode = $.effects.mode( el, mode );
1263+
normalizedMode = $.effects.mode( el, mode ) || defaultMode;
12641264

12651265
// save effect mode for later use,
12661266
// we can't just call $.effects.mode again later,
@@ -1279,7 +1279,7 @@ $.fn.extend({
12791279
},
12801280
queue = args.queue,
12811281
complete = args.complete,
1282-
mode = args.mode || defaultMode;
1282+
mode = args.mode;
12831283

12841284
if ( $.fx.off || !effectMethod ) {
12851285
// delegate to the original method (e.g., .show()) if possible

0 commit comments

Comments
 (0)