Skip to content

Commit 9ea6db6

Browse files
committed
Tabs: Only trigger tabsload on success.
1 parent 0adeb9b commit 9ea6db6

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

tests/unit/tabs/tabs_deprecated.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,11 @@ asyncTest( "spinner", function() {
156156
equals( element.find( ".ui-tabs-nav li:eq(2) em" ).length, 1, "beforeload" );
157157
});
158158
element.one( "tabsload", function( event, ui ) {
159-
equals( element.find( ".ui-tabs-nav li:eq(2) em" ).length, 0, "load" );
160-
start();
159+
// wait until after the load finishes before checking for the spinner to be removed
160+
setTimeout(function() {
161+
equals( element.find( ".ui-tabs-nav li:eq(2) em" ).length, 0, "load" );
162+
start();
163+
}, 1 );
161164
});
162165
element.tabs( "option", "active", 2 );
163166
});

ui/jquery.ui.tabs.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -621,6 +621,7 @@ $.widget( "ui.tabs", {
621621
this.xhr
622622
.success(function( response ) {
623623
panel.html( response );
624+
self._trigger( "load", event, eventData );
624625
})
625626
.complete(function( jqXHR, status ) {
626627
if ( status === "abort" ) {
@@ -631,13 +632,11 @@ $.widget( "ui.tabs", {
631632
// "tabs" queue must not contain more than two elements,
632633
// which are the callbacks for the latest clicked tab...
633634
self.element.queue( "tabs", self.element.queue( "tabs" ).splice( -2, 2 ) );
634-
635-
delete this.xhr;
636635
}
637636

638637
self.lis.eq( index ).removeClass( "ui-tabs-loading" );
639638

640-
self._trigger( "load", event, eventData );
639+
delete self.xhr;
641640
});
642641
}
643642

0 commit comments

Comments
 (0)