Skip to content

Commit 36038c5

Browse files
committed
Effects: Allow all "effect" calls to default to default Mode.
This fixes the situation where calling e.g. .effect("highlight") was a no-op as if .show("highlight") was called.
1 parent 34ed9ed commit 36038c5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ui/effect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,7 +1256,7 @@ $.fn.extend({
12561256
effectPrefilter = function() {
12571257

12581258
var el = $( this ),
1259-
normalizedMode = $.effects.mode( el, mode );
1259+
normalizedMode = $.effects.mode( el, mode ) || defaultMode;
12601260

12611261
// save effect mode for later use,
12621262
// we can't just call $.effects.mode again later,
@@ -1275,7 +1275,7 @@ $.fn.extend({
12751275
},
12761276
queue = args.queue,
12771277
complete = args.complete,
1278-
mode = args.mode || defaultMode;
1278+
mode = args.mode;
12791279

12801280
if ( $.fx.off || !effectMethod ) {
12811281
// delegate to the original method (e.g., .show()) if possible

0 commit comments

Comments
 (0)