From be41f9ca8aa9566cd4e3d79e81852973dcc93e07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?=
 <m.goleb@gmail.com>
Date: Thu, 10 Oct 2024 01:30:55 +0200
Subject: [PATCH] Tests: Run tests on both real Firefox ESRs

1. At the same time, there may be two supported versions of Firefox ESR. Run
   tests on both, installed locally.
2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's
   an ESR version of Firefox 115, but ESR versions may be different, e.g. for
   some time ServiceWorker was disabled on ESR versions:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1547023

Ref jquery/jquery#5547
---
 .github/workflows/browser-tests.yml | 23 +++++++++++++++++++++++
 .github/workflows/browserstack.yml  |  1 -
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/browser-tests.yml b/.github/workflows/browser-tests.yml
index 885d52a..2e3ee83 100644
--- a/.github/workflows/browser-tests.yml
+++ b/.github/workflows/browser-tests.yml
@@ -22,6 +22,12 @@ jobs:
           - NAME: "Node"
             BROWSER: "chrome"
             MIGRATE_VERSION: "esmodules"
+          - NAME: "Firefox ESR (new)"
+            BROWSER: "firefox"
+            MIGRATE_VERSION: "min"
+          - NAME: "Firefox ESR (old)"
+            BROWSER: "firefox"
+            MIGRATE_VERSION: "min"
     steps:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -39,6 +45,23 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
 
+      - name: Set download URL for Firefox ESR (old)
+        run: |
+            echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
+        if: contains(matrix.NAME, 'Firefox ESR (old)')
+
+      - name: Set download URL for Firefox ESR (new)
+        run: |
+            echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-next-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
+        if: contains(matrix.NAME, 'Firefox ESR (new)')
+
+      - name: Install Firefox ESR
+        run: |
+            wget --no-verbose $FIREFOX_SOURCE_URL -O - | tar -jx -C ${HOME}
+            echo "PATH=${HOME}/firefox:$PATH" >> "$GITHUB_ENV"
+            echo "FIREFOX_BIN=${HOME}/firefox/firefox" >> "$GITHUB_ENV"
+        if: contains(matrix.NAME, 'Firefox ESR')
+
       - name: Install dependencies
         run: npm install
 
diff --git a/.github/workflows/browserstack.yml b/.github/workflows/browserstack.yml
index 6da8c83..45d83e4 100644
--- a/.github/workflows/browserstack.yml
+++ b/.github/workflows/browserstack.yml
@@ -34,7 +34,6 @@ jobs:
           - 'Edge_latest-1'
           - 'Firefox_latest'
           - 'Firefox_latest-1'
-          - 'Firefox_115'
           - '__iOS_18'
           - '__iOS_17'
           - '__iOS_16'