From b2b5f5c09136c06ff09d7d83793b0e553aac394a Mon Sep 17 00:00:00 2001 From: Artur Chrusciel Date: Fri, 15 Jun 2018 08:19:21 +0200 Subject: [PATCH 1/3] No depracation warning on instantiating dirs --- fs.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/fs.js b/fs.js index 2b4b3ba78..54807adf4 100644 --- a/fs.js +++ b/fs.js @@ -20,17 +20,8 @@ const dirs = { MovieDir : RNFetchBlob.MovieDir, DownloadDir : RNFetchBlob.DownloadDir, DCIMDir : RNFetchBlob.DCIMDir, - get SDCardDir() { - console.warn('SDCardDir as a constant is deprecated and will be removed in feature release. ' + - 'Use RNFetchBlob.android.getSDCardDir():Promise instead.'); - return RNFetchBlob.SDCardDir; - }, - get SDCardApplicationDir() { - console.warn('SDCardApplicationDir as a constant is deprecated and will be removed in feature release. ' + - 'Use RNFetchBlob.android.getSDCardApplicationDir():Promise instead. ' + - 'This variable can be empty on error in native code.'); - return RNFetchBlob.SDCardApplicationDir; - }, + SDCardDir: RNFetchBlob.SDCardDir, + SDCardApplicationDir: RNFetchBlob.SDCardApplicationDir, MainBundleDir : RNFetchBlob.MainBundleDir, LibraryDir : RNFetchBlob.LibraryDir } From 63432aee1b8eeea00148959b272c61680fb3601f Mon Sep 17 00:00:00 2001 From: Artur Chrusciel Date: Fri, 15 Jun 2018 08:24:14 +0200 Subject: [PATCH 2/3] Depracation comment in code --- fs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs.js b/fs.js index 54807adf4..52e547c47 100644 --- a/fs.js +++ b/fs.js @@ -21,8 +21,8 @@ const dirs = { DownloadDir : RNFetchBlob.DownloadDir, DCIMDir : RNFetchBlob.DCIMDir, SDCardDir: RNFetchBlob.SDCardDir, - SDCardApplicationDir: RNFetchBlob.SDCardApplicationDir, - MainBundleDir : RNFetchBlob.MainBundleDir, + SDCardApplicationDir: RNFetchBlob.SDCardApplicationDir, // Deprecated + MainBundleDir : RNFetchBlob.MainBundleDir, // Depracated LibraryDir : RNFetchBlob.LibraryDir } From c7374e783c69fab65751c6186cdc4a76dba255c1 Mon Sep 17 00:00:00 2001 From: Artur Chrusciel Date: Fri, 15 Jun 2018 08:24:48 +0200 Subject: [PATCH 3/3] Depracated comment fix --- fs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs.js b/fs.js index 52e547c47..e61f44312 100644 --- a/fs.js +++ b/fs.js @@ -20,9 +20,9 @@ const dirs = { MovieDir : RNFetchBlob.MovieDir, DownloadDir : RNFetchBlob.DownloadDir, DCIMDir : RNFetchBlob.DCIMDir, - SDCardDir: RNFetchBlob.SDCardDir, + SDCardDir: RNFetchBlob.SDCardDir, // Depracated SDCardApplicationDir: RNFetchBlob.SDCardApplicationDir, // Deprecated - MainBundleDir : RNFetchBlob.MainBundleDir, // Depracated + MainBundleDir : RNFetchBlob.MainBundleDir, LibraryDir : RNFetchBlob.LibraryDir }