Skip to content

Commit f9814d2

Browse files
authored
fix: remove @types/jsdom dependency (#12107)
1 parent 26abf9a commit f9814d2

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88

99
### Performance
1010

11+
## 27.4.3
12+
13+
### Fixes
14+
15+
- `[jest-environment-jsdom]` Remove `@types/jsdom` dependency (and make its `dom` property `private`) ([#12107](https://github.com/facebook/jest/pull/12107))
16+
1117
## 27.4.2
1218

1319
### Fixes

packages/jest-environment-jsdom/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
"@jest/environment": "^27.4.2",
2121
"@jest/fake-timers": "^27.4.2",
2222
"@jest/types": "^27.4.2",
23-
"@types/jsdom": "^16.2.4",
2423
"@types/node": "*",
2524
"jest-mock": "^27.4.2",
2625
"jest-util": "^27.4.2",
2726
"jsdom": "^16.6.0"
2827
},
2928
"devDependencies": {
30-
"@jest/test-utils": "^27.4.2"
29+
"@jest/test-utils": "^27.4.2",
30+
"@types/jsdom": "^16.2.4"
3131
},
3232
"engines": {
3333
"node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"

packages/jest-environment-jsdom/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ type Win = Window &
2323
};
2424

2525
class JSDOMEnvironment implements JestEnvironment<number> {
26-
dom: JSDOM | null;
26+
private dom: JSDOM | null;
2727
fakeTimers: LegacyFakeTimers<number> | null;
2828
fakeTimersModern: ModernFakeTimers | null;
2929
global: Win;
30-
errorEventListener: ((event: Event & {error: Error}) => void) | null;
30+
private errorEventListener: ((event: Event & {error: Error}) => void) | null;
3131
moduleMocker: ModuleMocker | null;
3232

3333
constructor(config: Config.ProjectConfig, options?: EnvironmentContext) {

0 commit comments

Comments
 (0)