Skip to content

Commit f47cc3c

Browse files
y-hsgwy-hsgw
authored
refactor: remove unneeded as consts (#1578)
1 parent 6c1f921 commit f47cc3c

File tree

4 files changed

+31
-31
lines changed

4 files changed

+31
-31
lines changed

‎src/rules/prefer-lowercase-title.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export default createRule<
9292
additionalProperties: false,
9393
},
9494
],
95-
} as const,
95+
},
9696
defaultOptions: [
9797
{ ignore: [], allowedPrefixes: [], ignoreTopLevelDescribe: false },
9898
],

‎src/rules/utils/__tests__/detectJestVersion.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ describe('detectJestVersion', () => {
115115
it('finds the correct version', () => {
116116
const projectDir = setupFakeProject({
117117
'package.json': { name: 'simple-project' },
118-
[`node_modules/${relativePathToFn}` as const]: compiledFn,
118+
[`node_modules/${relativePathToFn}`]: compiledFn,
119119
'node_modules/jest/package.json': {
120120
name: 'jest',
121121
version: '21.0.0',
@@ -133,7 +133,7 @@ describe('detectJestVersion', () => {
133133
it('finds the correct version', () => {
134134
const projectDir = setupFakeProject({
135135
'package.json': { name: 'mono-repo' },
136-
[`node_modules/${relativePathToFn}` as const]: compiledFn,
136+
[`node_modules/${relativePathToFn}`]: compiledFn,
137137
'node_modules/jest/package.json': {
138138
name: 'jest',
139139
version: '19.0.0',
@@ -153,13 +153,13 @@ describe('detectJestVersion', () => {
153153
it('finds the correct versions', () => {
154154
const projectDir = setupFakeProject({
155155
'backend/package.json': { name: 'package-a' },
156-
[`backend/node_modules/${relativePathToFn}` as const]: compiledFn,
156+
[`backend/node_modules/${relativePathToFn}`]: compiledFn,
157157
'backend/node_modules/jest/package.json': {
158158
name: 'jest',
159159
version: '24.0.0',
160160
},
161161
'frontend/package.json': { name: 'package-b' },
162-
[`frontend/node_modules/${relativePathToFn}` as const]: compiledFn,
162+
[`frontend/node_modules/${relativePathToFn}`]: compiledFn,
163163
'frontend/node_modules/jest/package.json': {
164164
name: 'jest',
165165
version: '15.0.0',
@@ -184,7 +184,7 @@ describe('detectJestVersion', () => {
184184
it('throws an error', () => {
185185
const projectDir = setupFakeProject({
186186
'package.json': { name: 'no-jest' },
187-
[`node_modules/${relativePathToFn}` as const]: compiledFn,
187+
[`node_modules/${relativePathToFn}`]: compiledFn,
188188
'node_modules/pack/package.json': { name: 'pack' },
189189
});
190190

@@ -199,7 +199,7 @@ describe('detectJestVersion', () => {
199199
it('uses the cached version', () => {
200200
const projectDir = setupFakeProject({
201201
'package.json': { name: 'no-jest' },
202-
[`node_modules/${relativePathToFn}` as const]: compiledFn,
202+
[`node_modules/${relativePathToFn}`]: compiledFn,
203203
'node_modules/jest/package.json': { name: 'jest', version: '26.0.0' },
204204
});
205205

‎src/rules/utils/__tests__/parseJestFnCall.test.ts

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ ruleTester.run('expect', rule, {
194194
parserOptions: { sourceType: 'script' },
195195
errors: [
196196
{
197-
messageId: 'details' as const,
197+
messageId: 'details',
198198
data: expectedParsedJestFnCallResultData({
199199
name: 'expect',
200200
type: 'expect',
@@ -220,7 +220,7 @@ ruleTester.run('expect', rule, {
220220
parserOptions: { sourceType: 'module' },
221221
errors: [
222222
{
223-
messageId: 'details' as const,
223+
messageId: 'details',
224224
data: expectedParsedJestFnCallResultData({
225225
name: 'expect',
226226
type: 'expect',
@@ -246,7 +246,7 @@ ruleTester.run('expect', rule, {
246246
parserOptions: { sourceType: 'module' },
247247
errors: [
248248
{
249-
messageId: 'details' as const,
249+
messageId: 'details',
250250
data: expectedParsedJestFnCallResultData({
251251
name: 'expect',
252252
type: 'expect',
@@ -272,7 +272,7 @@ ruleTester.run('expect', rule, {
272272
parserOptions: { sourceType: 'module' },
273273
errors: [
274274
{
275-
messageId: 'details' as const,
275+
messageId: 'details',
276276
data: expectedParsedJestFnCallResultData({
277277
name: 'expect',
278278
type: 'expect',
@@ -298,7 +298,7 @@ ruleTester.run('expect', rule, {
298298
parserOptions: { sourceType: 'module' },
299299
errors: [
300300
{
301-
messageId: 'details' as const,
301+
messageId: 'details',
302302
data: expectedParsedJestFnCallResultData({
303303
name: 'expect',
304304
type: 'expect',
@@ -327,7 +327,7 @@ ruleTester.run('expect', rule, {
327327
parserOptions: { sourceType: 'module' },
328328
errors: [
329329
{
330-
messageId: 'details' as const,
330+
messageId: 'details',
331331
data: expectedParsedJestFnCallResultData({
332332
name: 'expect',
333333
type: 'expect',
@@ -343,7 +343,7 @@ ruleTester.run('expect', rule, {
343343
line: 3,
344344
},
345345
{
346-
messageId: 'details' as const,
346+
messageId: 'details',
347347
data: expectedParsedJestFnCallResultData({
348348
name: 'expect',
349349
type: 'expect',
@@ -359,7 +359,7 @@ ruleTester.run('expect', rule, {
359359
line: 4,
360360
},
361361
{
362-
messageId: 'details' as const,
362+
messageId: 'details',
363363
data: expectedParsedJestFnCallResultData({
364364
name: 'expect',
365365
type: 'expect',
@@ -375,7 +375,7 @@ ruleTester.run('expect', rule, {
375375
line: 5,
376376
},
377377
{
378-
messageId: 'details' as const,
378+
messageId: 'details',
379379
data: expectedParsedJestFnCallResultData({
380380
name: 'expect',
381381
type: 'expect',
@@ -493,7 +493,7 @@ if (eslintVersion >= 8) {
493493
parserOptions: { sourceType: 'module', ecmaVersion: 2022 },
494494
errors: [
495495
{
496-
messageId: 'details' as const,
496+
messageId: 'details',
497497
data: expectedParsedJestFnCallResultData({
498498
name: 'it',
499499
type: 'test',
@@ -519,7 +519,7 @@ if (eslintVersion >= 8) {
519519
parserOptions: { sourceType: 'module', ecmaVersion: 2022 },
520520
errors: [
521521
{
522-
messageId: 'details' as const,
522+
messageId: 'details',
523523
data: expectedParsedJestFnCallResultData({
524524
name: 'it',
525525
type: 'test',
@@ -630,7 +630,7 @@ ruleTester.run('global aliases', rule, {
630630
code: 'context("when there is an error", () => {})',
631631
errors: [
632632
{
633-
messageId: 'details' as const,
633+
messageId: 'details',
634634
data: expectedParsedJestFnCallResultData({
635635
name: 'describe',
636636
type: 'describe',
@@ -652,7 +652,7 @@ ruleTester.run('global aliases', rule, {
652652
code: 'context.skip("when there is an error", () => {})',
653653
errors: [
654654
{
655-
messageId: 'details' as const,
655+
messageId: 'details',
656656
data: expectedParsedJestFnCallResultData({
657657
name: 'describe',
658658
type: 'describe',
@@ -677,7 +677,7 @@ ruleTester.run('global aliases', rule, {
677677
`,
678678
errors: [
679679
{
680-
messageId: 'details' as const,
680+
messageId: 'details',
681681
data: expectedParsedJestFnCallResultData({
682682
name: 'xdescribe',
683683
type: 'describe',
@@ -703,7 +703,7 @@ ruleTester.run('global aliases', rule, {
703703
`,
704704
errors: [
705705
{
706-
messageId: 'details' as const,
706+
messageId: 'details',
707707
data: expectedParsedJestFnCallResultData({
708708
name: 'describe',
709709
type: 'describe',
@@ -719,7 +719,7 @@ ruleTester.run('global aliases', rule, {
719719
line: 1,
720720
},
721721
{
722-
messageId: 'details' as const,
722+
messageId: 'details',
723723
data: expectedParsedJestFnCallResultData({
724724
name: 'describe',
725725
type: 'describe',
@@ -794,7 +794,7 @@ ruleTester.run('global package source', rule, {
794794
parserOptions: { sourceType: 'script' },
795795
errors: [
796796
{
797-
messageId: 'details' as const,
797+
messageId: 'details',
798798
data: expectedParsedJestFnCallResultData({
799799
name: 'expect',
800800
type: 'expect',
@@ -825,7 +825,7 @@ ruleTester.run('global package source', rule, {
825825
parserOptions: { sourceType: 'module' },
826826
errors: [
827827
{
828-
messageId: 'details' as const,
828+
messageId: 'details',
829829
data: expectedParsedJestFnCallResultData({
830830
name: 'describe',
831831
type: 'describe',
@@ -841,7 +841,7 @@ ruleTester.run('global package source', rule, {
841841
line: 3,
842842
},
843843
{
844-
messageId: 'details' as const,
844+
messageId: 'details',
845845
data: expectedParsedJestFnCallResultData({
846846
name: 'it',
847847
type: 'test',
@@ -857,7 +857,7 @@ ruleTester.run('global package source', rule, {
857857
line: 4,
858858
},
859859
{
860-
messageId: 'details' as const,
860+
messageId: 'details',
861861
data: expectedParsedJestFnCallResultData({
862862
name: 'expect',
863863
type: 'expect',
@@ -884,7 +884,7 @@ ruleTester.run('global package source', rule, {
884884
parserOptions: { sourceType: 'module' },
885885
errors: [
886886
{
887-
messageId: 'details' as const,
887+
messageId: 'details',
888888
data: expectedParsedJestFnCallResultData({
889889
name: 'expect',
890890
type: 'expect',
@@ -906,7 +906,7 @@ ruleTester.run('global package source', rule, {
906906
code: 'context("when there is an error", () => {})',
907907
errors: [
908908
{
909-
messageId: 'details' as const,
909+
messageId: 'details',
910910
data: expectedParsedJestFnCallResultData({
911911
name: 'describe',
912912
type: 'describe',
@@ -1013,7 +1013,7 @@ ruleTester.run('typescript', rule, {
10131013
parserOptions: { sourceType: 'module' },
10141014
errors: [
10151015
{
1016-
messageId: 'details' as const,
1016+
messageId: 'details',
10171017
data: expectedParsedJestFnCallResultData({
10181018
name: 'it',
10191019
type: 'test',

‎src/rules/valid-title.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ const MatcherAndMessageSchema: JSONSchema.JSONSchema4 = {
8080
minItems: 1,
8181
maxItems: 2,
8282
additionalItems: false,
83-
} as const;
83+
};
8484

8585
type MatcherGroups = 'describe' | 'test' | 'it';
8686

0 commit comments

Comments
 (0)