Skip to content

Commit e9b670e

Browse files
Merge pull request #50 from angular/master
Update upstream
2 parents c1844d8 + 3f95ae2 commit e9b670e

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

Gruntfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ module.exports = function(grunt) {
315315
files: [
316316
// The source files are needed by the embedded examples in the docs app.
317317
{
318-
src: 'build/angular*.{js.map,min.js}',
318+
src: 'build/angular*.{js,js.map,min.js}',
319319
dest: 'uploadDocs/',
320320
expand: true,
321321
flatten: true

docs/content/guide/external-resources.ngdoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ This is a collection of external, 3rd party resources for learning and developin
4848

4949
* **Django:** [Tutorial](http://blog.mourafiq.com/post/55034504632/end-to-end-web-app-with-django-rest-framework), [Integrating AngularJS with Django](http://django-angular.readthedocs.org/en/latest/integration.html), [Getting Started with Django Rest Framework and AngularJS](http://blog.kevinastone.com/getting-started-with-django-rest-framework-and-angularjs.html)
5050
* **FireBase:** [AngularFire](http://angularfire.com/), [Realtime Apps with AngularJS and FireBase (video)](http://www.youtube.com/watch?v=C7ZI7z7qnHU)
51-
* **Google Cloud Platform: **[with Cloud Endpoints](https://cloud.google.com/developers/articles/angularjs-cloud-endpoints-recipe-for-building-modern-web-applications/), [with Go](https://github.com/GoogleCloudPlatform/appengine-angular-gotodos)
51+
* **Google Cloud Platform:** [with Go](https://github.com/GoogleCloudPlatform/appengine-angular-gotodos)
5252
* **Hood.ie:** [60 Minutes to Awesome](http://www.roberthorvick.com/2013/06/30/todomvc-angularjs-hood-ie-60-minutes-to-awesome/)
5353
* **MEAN Stack: **[Blog post](http://blog.mongodb.org/post/49262866911/the-mean-stack-mongodb-expressjs-angularjs-and), [Setup](http://thecodebarbarian.wordpress.com/2013/07/22/introduction-to-the-mean-stack-part-one-setting-up-your-tools/), [GDL Video](https://developers.google.com/live/shows/913996610)
5454
* **Rails: **[Tutorial](http://coderberry.me/blog/2013/04/22/angularjs-on-rails-4-part-1/), [AngularJS with Rails4](https://shellycloud.com/blog/2013/10/how-to-integrate-angularjs-with-rails-4), [angularjs-rails](https://github.com/hiravgandhi/angularjs-rails)

scripts/code.angularjs.org-firebase/functions/index.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,8 @@ function sendStoredFile(request, response) {
6161
return new Promise((resolve, reject) => {
6262

6363
const readStream = file.createReadStream()
64-
.on('error', error => {
65-
reject(error);
66-
})
67-
.on('response', () => {
68-
resolve(response);
69-
});
64+
.on('error', reject)
65+
.on('finish', resolve);
7066

7167
response
7268
.status(200)
@@ -75,7 +71,7 @@ function sendStoredFile(request, response) {
7571
'Cache-Control': `public, max-age=${BROWSER_CACHE_DURATION}, s-maxage=${CDN_CACHE_DURATION}`
7672
});
7773

78-
readStream.pipe(response);
74+
readStream.pipe(response);
7975
});
8076

8177
});

0 commit comments

Comments
 (0)