From 78cd7cf4b50b236dcbad2d74fbcc3d4cd226a116 Mon Sep 17 00:00:00 2001 From: Valentyn Kolesnikov Date: Thu, 27 Jun 2024 10:49:09 +0300 Subject: [PATCH] Improved tests --- src/main/java/g1101_1200/s1117_building_h2o/H2O.java | 8 ++++++-- .../Solution.java | 3 --- .../SolutionTest.java | 7 +++---- .../SolutionTest.java | 11 +++++------ .../s0519_random_flip_matrix/SolutionTest.java | 9 ++++----- 5 files changed, 18 insertions(+), 20 deletions(-) diff --git a/src/main/java/g1101_1200/s1117_building_h2o/H2O.java b/src/main/java/g1101_1200/s1117_building_h2o/H2O.java index 13a1e56a7..2e5c3cbc6 100644 --- a/src/main/java/g1101_1200/s1117_building_h2o/H2O.java +++ b/src/main/java/g1101_1200/s1117_building_h2o/H2O.java @@ -35,10 +35,12 @@ public HydrogenRunnable(H2O h2O) { this.h2O = h2O; } + private static void run2() {} + @Override public void run() { try { - h2O.hydrogen(() -> System.out.print('H')); + h2O.hydrogen(HydrogenRunnable::run2); } catch (InterruptedException ignored) { // ignored } @@ -52,10 +54,12 @@ public OxygenRunnable(H2O h2O) { this.h2O = h2O; } + private static void run2() {} + @Override public void run() { try { - h2O.oxygen(() -> System.out.print('O')); + h2O.oxygen(OxygenRunnable::run2); } catch (InterruptedException ignored) { // ignored } diff --git a/src/main/java/g1401_1500/s1489_find_critical_and_pseudo_critical_edges_in_minimum_spanning_tree/Solution.java b/src/main/java/g1401_1500/s1489_find_critical_and_pseudo_critical_edges_in_minimum_spanning_tree/Solution.java index 62e06b709..17f6e8c71 100644 --- a/src/main/java/g1401_1500/s1489_find_critical_and_pseudo_critical_edges_in_minimum_spanning_tree/Solution.java +++ b/src/main/java/g1401_1500/s1489_find_critical_and_pseudo_critical_edges_in_minimum_spanning_tree/Solution.java @@ -48,9 +48,6 @@ public List> findCriticalAndPseudoCriticalEdges(int n, int[][] edg pce.addAll(cur); pce.add(ind); } - if (!p) { - System.out.println("Should not reach here"); - } } } // critical edges diff --git a/src/test/java/g0401_0500/s0478_generate_random_point_in_a_circle/SolutionTest.java b/src/test/java/g0401_0500/s0478_generate_random_point_in_a_circle/SolutionTest.java index 0eab9f55d..9a7ec84a4 100644 --- a/src/test/java/g0401_0500/s0478_generate_random_point_in_a_circle/SolutionTest.java +++ b/src/test/java/g0401_0500/s0478_generate_random_point_in_a_circle/SolutionTest.java @@ -3,16 +3,15 @@ import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.MatcherAssert.assertThat; -import com_github_leetcode.CommonUtils; import org.junit.jupiter.api.Test; class SolutionTest { @Test void randPoint() { Solution solution = new Solution(1.0, 0.0, 0.0); - CommonUtils.printArray(solution.randPoint()); - CommonUtils.printArray(solution.randPoint()); - CommonUtils.printArray(solution.randPoint()); + solution.randPoint(); + solution.randPoint(); + solution.randPoint(); assertThat(solution, equalTo(solution)); } } diff --git a/src/test/java/g0401_0500/s0497_random_point_in_non_overlapping_rectangles/SolutionTest.java b/src/test/java/g0401_0500/s0497_random_point_in_non_overlapping_rectangles/SolutionTest.java index bf75651df..71182eaf8 100644 --- a/src/test/java/g0401_0500/s0497_random_point_in_non_overlapping_rectangles/SolutionTest.java +++ b/src/test/java/g0401_0500/s0497_random_point_in_non_overlapping_rectangles/SolutionTest.java @@ -3,18 +3,17 @@ import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.MatcherAssert.assertThat; -import com_github_leetcode.CommonUtils; import org.junit.jupiter.api.Test; class SolutionTest { @Test void solutionTest() { Solution solution = new Solution(new int[][] {{-2, -2, 1, 1}, {2, 2, 4, 6}}); - CommonUtils.printArray(solution.pick()); - CommonUtils.printArray(solution.pick()); - CommonUtils.printArray(solution.pick()); - CommonUtils.printArray(solution.pick()); - CommonUtils.printArray(solution.pick()); + solution.pick(); + solution.pick(); + solution.pick(); + solution.pick(); + solution.pick(); assertThat(true, equalTo(true)); } } diff --git a/src/test/java/g0501_0600/s0519_random_flip_matrix/SolutionTest.java b/src/test/java/g0501_0600/s0519_random_flip_matrix/SolutionTest.java index 72162e695..9cb194b93 100644 --- a/src/test/java/g0501_0600/s0519_random_flip_matrix/SolutionTest.java +++ b/src/test/java/g0501_0600/s0519_random_flip_matrix/SolutionTest.java @@ -3,18 +3,17 @@ import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.MatcherAssert.assertThat; -import com_github_leetcode.CommonUtils; import org.junit.jupiter.api.Test; class SolutionTest { @Test void solutionTest() { Solution solution = new Solution(3, 1); - CommonUtils.printArray(solution.flip()); - CommonUtils.printArray(solution.flip()); - CommonUtils.printArray(solution.flip()); + solution.flip(); + solution.flip(); + solution.flip(); solution.reset(); - CommonUtils.printArray(solution.flip()); + solution.flip(); assertThat(true, equalTo(true)); } }