Skip to content

Commit f945f0a

Browse files
committed
Update tests to use existing files on disk. Fixes failing tests.
1 parent 6f700a4 commit f945f0a

File tree

1 file changed

+27
-19
lines changed

1 file changed

+27
-19
lines changed

test_zipp.py

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -418,22 +418,30 @@ def test_inheritance(self, alpharep):
418418
file = cls(alpharep).joinpath('some dir').parent
419419
assert isinstance(file, cls)
420420

421-
def test_can_pickle_string_path(self):
422-
path_1 = zipp.Path("/path/to/a/file.zip")
423-
path_1_pickle = pickle.dumps(path_1)
424-
path_1_load = pickle.loads(path_1_pickle)
425-
assert path_1.root == path_1_load.root
426-
path_2 = zipp.Path("/path/to/a/file.zip", at="something.txt")
427-
path_2_pickle = pickle.dumps(path_2)
428-
path_2_load = pickle.loads(path_2_pickle)
429-
assert path_2.root == path_2_load.root
430-
431-
def test_can_pickle_pathlib_path(self):
432-
path_1 = zipp.Path(pathlib.Path("/path/to/a/file.zip"))
433-
path_1_pickle = pickle.dumps(path_1)
434-
path_1_load = pickle.loads(path_1_pickle)
435-
assert path_1.root == path_1_load.root
436-
path_2 = zipp.Path(pathlib.Path("/path/to/a/file.zip", at="something.txt"))
437-
path_2_pickle = pickle.dumps(path_2)
438-
path_2_load = pickle.loads(path_2_pickle)
439-
assert path_2.root == path_2_load.root
421+
@pass_alpharep
422+
def test_can_pickle_string_path(self, alpharep):
423+
zipfile_ondisk = str(self.zipfile_ondisk(alpharep))
424+
425+
saved_1 = pickle.dumps(zipp.Path(zipfile_ondisk))
426+
restored_1 = pickle.loads(saved_1)
427+
a, b, g = restored_1.iterdir()
428+
assert a.read_text() == "content of a"
429+
430+
saved_2 = pickle.dumps(zipp.Path(zipfile_ondisk, at="b/"))
431+
restored_2 = pickle.loads(saved_2)
432+
c, d, f = restored_2.iterdir()
433+
assert c.read_text() == 'content of c'
434+
435+
@pass_alpharep
436+
def test_can_pickle_pathlib_path(self, alpharep):
437+
zipfile_ondisk = self.zipfile_ondisk(alpharep)
438+
439+
saved_1 = pickle.dumps(zipp.Path(zipfile_ondisk))
440+
restored_1 = pickle.loads(saved_1)
441+
a, b, g = restored_1.iterdir()
442+
assert a.read_text() == "content of a"
443+
444+
saved_2 = pickle.dumps(zipp.Path(zipfile_ondisk, at="b/"))
445+
restored_2 = pickle.loads(saved_2)
446+
c, d, f = restored_2.iterdir()
447+
assert c.read_text() == 'content of c'

0 commit comments

Comments
 (0)