fix: prevent OOM on very deep DAGs #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor exporting files to use a queue instead of recursion to walk the DAG. The queue exectutes on a new stack so we won't run out of memory when traversing very deep DAGs.
|
@achingbrain : is there test coverage around this, at least guaranteeing we haven't broken anything, even if we're not proving that we have fixed things? |
|
@BigLep there is plenty of test coverage of this file - we have codecov set up but for some reason we don't get the report as a comment on the PR. Digging through the CI logs, this is the report - https://app.codecov.io/github/ipfs/js-ipfs-unixfs/commit/890c43c978e84e608699284fb435b2a5d86de2ee |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
## [ipfs-unixfs-exporter-v8.0.6](ipfs-unixfs-exporter-v8.0.5...ipfs-unixfs-exporter-v8.0.6) (2022-09-21) ### Bug Fixes * prevent OOM on very deep DAGs ([#253](#253)) ([62494bf](62494bf))
|
🎉 This PR is included in version ipfs-unixfs-exporter-v8.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor exporting files to use a queue instead of recursion to walk the DAG. The queue exectutes on a new stack so we won't run out of memory when traversing very deep DAGs.