Removing error message assertions

License: MIT
Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>

Author: AuHau

test/index.spec.js

@@ -87,22 +87,22 @@ describe('index.js', () => {
 
     expect(
       () => migrator.getLatestMigrationVersion([])
-    ).to.throw(errors.InvalidValueError, 'Migrations must be non-empty array!').with.property('code', errors.InvalidValueError.code)
+    ).to.throw(errors.InvalidValueError).with.property('code', errors.InvalidValueError.code)
   })
 
   describe('revert', () => {
     it('should error with out path argument', () => {
       const options = createOptions()
 
       return expect(migrator.revert(undefined, undefined, options))
-        .to.eventually.be.rejectedWith(errors.RequiredParameterError, 'Path argument is required!').with.property('code', errors.RequiredParameterError.code)
+        .to.eventually.be.rejectedWith(errors.RequiredParameterError).with.property('code', errors.RequiredParameterError.code)
     })
 
     it('should error with out toVersion argument', () => {
       const options = createOptions()
 
       return expect(migrator.revert('/some/path', undefined, options))
-        .to.eventually.be.rejectedWith(errors.RequiredParameterError, 'When reverting migrations, you have to specify to which version to revert!').with.property('code', errors.RequiredParameterError.code)
+        .to.eventually.be.rejectedWith(errors.RequiredParameterError).with.property('code', errors.RequiredParameterError.code)
     })
 
     it('should error with invalid toVersion argument', () => {
@@ -111,7 +111,7 @@ describe('index.js', () => {
 
       return Promise.all(
         invalidValues.map((value) => expect(migrator.revert('/some/path', value, options))
-          .to.eventually.be.rejectedWith(errors.InvalidValueError, 'Version has to be positive integer!').with.property('code', errors.InvalidValueError.code))
+          .to.eventually.be.rejectedWith(errors.InvalidValueError).with.property('code', errors.InvalidValueError.code))
       )
     })
 
@@ -143,7 +143,7 @@ describe('index.js', () => {
       getVersionStub.returns(4)
       return expect(
         migrator.revert('/some/path', 1, options)
-      ).to.eventually.be.rejectedWith(errors.NonReversibleMigrationError, 'Migration version 3 is not possible to revert! Cancelling reversion.')
+      ).to.eventually.be.rejectedWith(errors.NonReversibleMigrationError)
         .with.property('code', errors.NonReversibleMigrationError.code)
     })
 
@@ -272,15 +272,15 @@ describe('index.js', () => {
       const options = createOptions()
 
       return expect(migrator.migrate(undefined, options))
-        .to.eventually.be.rejectedWith(errors.RequiredParameterError, 'Path argument is required!').with.property('code', errors.RequiredParameterError.code)
+        .to.eventually.be.rejectedWith(errors.RequiredParameterError).with.property('code', errors.RequiredParameterError.code)
     })
 
     it('should error with invalid toVersion argument', () => {
       const invalidValues = ['eight', '-1', '1', -1]
 
       return Promise.all(
         invalidValues.map((invalidValue) => expect(migrator.migrate('/some/path', createOptions(invalidValue)))
-          .to.eventually.be.rejectedWith(errors.InvalidValueError, 'Version has to be positive integer!').with.property('code', errors.InvalidValueError.code))
+          .to.eventually.be.rejectedWith(errors.InvalidValueError).with.property('code', errors.InvalidValueError.code))
       )
     })
 

test/version-test.js

@@ -8,13 +8,15 @@ const Datastore = require('datastore-fs')
 const Key = require('interface-datastore').Key
 const version = require('../src/repo/version')
 
+const errors = require('../src/errors')
+
 // When new versioning mechanism is introduced in new version don't forget to update
 // the range (from/to) of the previous version test's description
 
 module.exports = (setup, cleanup) => {
   it('getVersion should fail without any version in repo', async () => {
     const dir = await setup()
-    await expect(version.getVersion(dir)).to.be.eventually.rejectedWith('Repo does not have version file! Is the repo initialized?')
+    await expect(version.getVersion(dir)).to.be.eventually.rejectedWith(errors.UnknownRepoStructureError).with.property('code', errors.UnknownRepoStructureError.code)
     return cleanup(dir)
   })
 
@@ -40,7 +42,7 @@ module.exports = (setup, cleanup) => {
     })
 
     it('should set version number', async () => {
-      await expect(version.getVersion(dir)).to.be.eventually.rejectedWith('Repo does not have version file! Is the repo initialized?')
+      await expect(version.getVersion(dir)).to.be.eventually.rejectedWith(errors.UnknownRepoStructureError).with.property('code', errors.UnknownRepoStructureError.code)
       await version.setVersion(dir, 7)
       expect(await version.getVersion(dir)).to.be.equal(7)
     })