Add error handling for if res.arrayBuffer() throws an error after making a ky request

[pcowgill]

This is where you might want to handle the error:

https://github.com/ipfs/js-ipfs-http-client/blob/3e5967af8e456517485c8a7536792107c0ed6e63/src/block/get.js#L21

[pcowgill]

@achingbrain @hugomrdias How do you prefer to handle a case like this?

    const res = await ky.post("block/get", {
      timeout: options.timeout,
      signal: options.signal,
      headers: options.headers,
      searchParams
    });

    try {
      const data = res.arrayBuffer();
      return new Block(Buffer.from(data), cid);
    } catch (error) {
      throw new Error("Error parsing ky response");
    }

How do you prefer to handle this? Throw a custom error from scratch like is done above? Just let the original error bubble through but have it be clearer by having the arrayBuffer step on its own line? Customize the existing error's message or name and throw that?

[alanshaw]

@pcowgill why do we need additional handling here?

[pcowgill]

@alanshaw The error message that bubbles all the way up without a try/catch is a bit opaque, and stack trace line numbers aren’t always reliable in React Native, especially when networking is involved so you can’t result the Chrome debugger. A custom error message that handled the case where it was undefined would have made it simpler as a dev using this lib to immediately know what wasn’t configured properly

[alanshaw]

What is the error you're receiving?

[autonome]

Closing as there was no response - @pcowgill Please reopen if this is still an issue!