From e62a147356d1cd08a0e58d4392be33a5cf105b05 Mon Sep 17 00:00:00 2001 From: David Dias Date: Sun, 5 Jun 2016 17:09:29 +0100 Subject: [PATCH 1/2] update aegir --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index ac57b0fe4..4a60a42f2 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "url": "https://github.com/ipfs/js-ipfs-api" }, "devDependencies": { - "aegir": "^3.0.4", + "aegir": "^3.2.0", "chai": "^3.5.0", "gulp": "^3.9.1", "interface-ipfs-core": "^0.1.4", @@ -90,4 +90,4 @@ "url": "https://github.com/ipfs/js-ipfs-api/issues" }, "homepage": "https://github.com/ipfs/js-ipfs-api" -} \ No newline at end of file +} From dd28cb6a6858bcbd94a1bf4b977e599e139f8858 Mon Sep 17 00:00:00 2001 From: David Dias Date: Sun, 5 Jun 2016 19:22:23 +0100 Subject: [PATCH 2/2] migrate require raw to readFileSync --- .aegir.js | 11 +++-------- package.json | 4 ++-- test/api/add.spec.js | 22 ++++++---------------- test/api/cat.spec.js | 12 +++++------- test/api/files.spec.js | 6 +----- 5 files changed, 17 insertions(+), 38 deletions(-) diff --git a/.aegir.js b/.aegir.js index e179f1476..3245972ba 100644 --- a/.aegir.js +++ b/.aegir.js @@ -2,14 +2,9 @@ module.exports = { webpack: { - module: { - postLoaders: [{ - test: /\.js$/, - loader: 'transform?brfs', - exclude: [ - /js-ipfs-api\/test/ - ] - }] + externals: { + fs: '{}', + mkdirp: '{}' } } } diff --git a/package.json b/package.json index 4a60a42f2..0051aa6b4 100644 --- a/package.json +++ b/package.json @@ -33,9 +33,9 @@ "interface-ipfs-core": "^0.1.4", "ipfsd-ctl": "^0.14.0", "pre-commit": "^1.1.2", - "raw-loader": "^0.5.1", "stream-equal": "^0.1.8", - "stream-http": "^2.2.0" + "stream-http": "^2.2.0", + "streamifier": "^0.1.1" }, "scripts": { "test": "gulp test", diff --git a/test/api/add.spec.js b/test/api/add.spec.js index 6c09509ce..fd90138e7 100644 --- a/test/api/add.spec.js +++ b/test/api/add.spec.js @@ -8,19 +8,8 @@ const path = require('path') const isNode = require('detect-node') const fs = require('fs') -let testfile -let testfileBig -const testfilePath = path.join(__dirname, '/../testfile.txt') - -if (isNode) { - testfile = fs.readFileSync(testfilePath) - testfileBig = fs.createReadStream(path.join(__dirname, '/../15mb.random'), { bufferSize: 128 }) - // testfileBig = fs.createReadStream(path.join(__dirname, '/../100mb.random'), { bufferSize: 128 }) -} else { - testfile = require('raw!../testfile.txt') - // browser goes nuts with a 100mb in memory - // testfileBig = require('raw!../100mb.random') -} +const testfileBig = fs.readFileSync(path.join(__dirname, '/../15mb.random')) +const testfile = fs.readFileSync(path.join(__dirname, '/../testfile.txt')) describe('.add', () => { it('add file', (done) => { @@ -73,7 +62,7 @@ describe('.add', () => { return done() } - apiClients.a.add(testfilePath, (err, res) => { + apiClients.a.add(path.join(__dirname, '/../testfile.txt'), (err, res) => { expect(err).to.not.exist const added = res[0] != null ? res[0] : res @@ -122,8 +111,9 @@ describe('.add', () => { }) it('add a nested dir as array', (done) => { - if (!isNode) return done() - const fs = require('fs') + if (!isNode) { + return done() + } const base = path.join(__dirname, '../test-folder') const content = (name) => ({ path: `test-folder/${name}`, diff --git a/test/api/cat.spec.js b/test/api/cat.spec.js index d8c1e3070..0e5a9508e 100644 --- a/test/api/cat.spec.js +++ b/test/api/cat.spec.js @@ -5,6 +5,7 @@ const expect = require('chai').expect const isNode = require('detect-node') const fs = require('fs') +const streamifier = require('streamifier') const path = require('path') const streamEqual = require('stream-equal') @@ -12,12 +13,8 @@ const streamEqual = require('stream-equal') let testfile let testfileBig -if (isNode) { - testfile = fs.readFileSync(path.join(__dirname, '/../testfile.txt')) - testfileBig = fs.createReadStream(path.join(__dirname, '/../15mb.random'), { bufferSize: 128 }) -} else { - testfile = require('raw!../testfile.txt') -} +testfile = fs.readFileSync(path.join(__dirname, '/../testfile.txt')) +testfileBig = fs.readFileSync(path.join(__dirname, '/../15mb.random')) describe('.cat', () => { it('cat', (done) => { @@ -49,7 +46,8 @@ describe('.cat', () => { expect(err).to.not.exist // Do not blow out the memory of nodejs :) - streamEqual(res, testfileBig, (err, equal) => { + const bigStream = streamifier.createReadStream(testfileBig) + streamEqual(res, bigStream, (err, equal) => { expect(err).to.not.exist expect(equal).to.be.true done() diff --git a/test/api/files.spec.js b/test/api/files.spec.js index 5fa59913b..d46254c99 100644 --- a/test/api/files.spec.js +++ b/test/api/files.spec.js @@ -8,11 +8,7 @@ const path = require('path') let testfile -if (isNode) { - testfile = require('fs').readFileSync(path.join(__dirname, '/../testfile.txt')) -} else { - testfile = require('raw!../testfile.txt') -} +testfile = require('fs').readFileSync(path.join(__dirname, '/../testfile.txt')) describe('.files', () => { it('files.mkdir', (done) => {