Merge pull request #192 from ipfs/tests/options-version

add remaining version tests

Author: daviddias

README.md

@@ -69,9 +69,19 @@ The tests folder also contains great examples that can be used to understand how
 
 ### Core
 
-##### Block
+##### version
 
-##### Object
+- [examples](https://github.com/ipfs/js-ipfs-api/blob/master/test/api/version.spec.js)
+
+##### node
+
+> node start and stop are not implemented in the API
+
+- [examples](https://github.com/ipfs/js-ipfs-api/blob/master/test/api/id.spec.js)
+
+##### block
+
+##### object
 
 **Curl**
 ```sh
@@ -91,7 +101,7 @@ curl 'http://localhost:5001/api/v0/object/get?arg=QmYEqnfCZp7a39Gxrgyv3qRS4MoCTG
 ```
 *Data is base64 encoded.*
 
-##### Pin
+##### pin
 
 
 -------------------------------------------------------
@@ -147,8 +157,6 @@ curl 'http://localhost:5001/api/v0/add?stream-channels=true' \
 ```
 *The name value will only be set for actual files.*
 
-
-
 ##### cat
 
 Retrieve the contents of a single hash, or array of hashes.
@@ -219,7 +227,7 @@ curl "http://localhost:5001/api/v0/ls?arg=<hash>&stream-channels=true"
 }
 ```
 
-##### Update
+##### update
 
 -------------------------------------------------------
 

test/api/version.spec.js

@@ -1,11 +1,44 @@
 'use strict'
 
 describe('.version', () => {
+  // note, IPFS HTTP-API returns always the same object, the filtering
+  // happens on the CLI
   it('checks the version', done => {
     apiClients['a'].version((err, res) => {
       expect(err).to.not.exist
       expect(res).to.have.a.property('Version')
-      console.log('      - running against version', res.Version)
+      expect(res).to.have.a.property('Commit')
+      expect(res).to.have.a.property('Repo')
+      done()
+    })
+  })
+
+  it('with number option', done => {
+    apiClients['a'].version({number: true}, (err, res) => {
+      expect(err).to.not.exist
+      expect(res).to.have.a.property('Version')
+      expect(res).to.have.a.property('Commit')
+      expect(res).to.have.a.property('Repo')
+      done()
+    })
+  })
+
+  it('with commit option', done => {
+    apiClients['a'].version({commit: true}, (err, res) => {
+      expect(err).to.not.exist
+      expect(res).to.have.a.property('Version')
+      expect(res).to.have.a.property('Commit')
+      expect(res).to.have.a.property('Repo')
+      done()
+    })
+  })
+
+  it('with repo option', done => {
+    apiClients['a'].version({commit: true}, (err, res) => {
+      expect(err).to.not.exist
+      expect(res).to.have.a.property('Version')
+      expect(res).to.have.a.property('Commit')
+      expect(res).to.have.a.property('Repo')
       done()
     })
   })