implement list and rm api and tests

Author: gavinmcdermott

src/api/bootstrap.js

@@ -1,17 +1,23 @@
 'use strict'
 
-// const command = require('../cmd-helpers').command
-// const argCommand = require('../cmd-helpers').argCommand
+const command = require('../cmd-helpers').command
 
 module.exports = (send) => {
   return {
-    add: function add (address, opts, cb) {
+    add: (arg, opts, cb) => {
       if (typeof opts === 'function' && cb === undefined) {
         cb = opts
         opts = {}
       }
-      // var send = function (path, args, qs, files, buffer, cb) {
-      return send('bootstrap/add', address, opts, null, cb)
-    }
+      return send('bootstrap/add', arg, opts, null, cb)
+    },
+    rm: (arg, opts, cb) => {
+      if (typeof opts === 'function' && cb === undefined) {
+        cb = opts
+        opts = {}
+      }
+      return send('bootstrap/rm', arg, opts, null, cb)
+    },
+    list: command(send, 'bootstrap/list')
   }
 }

test/api/bootstrap.spec.js

@@ -3,53 +3,187 @@
 'use strict'
 
 const expect = require('chai').expect
-// const multiaddr = require('multiaddr')
 
-describe('.bootstrap', () => {
-  const emptyArg = ''
-  const invalidArg = 'QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ'
-  const validIp4 = '/ip4/104.236.176.52/tcp/4001/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z'
+const invalidArg = 'this/Is/So/Invalid/'
+const validIp4 = '/ip4/104.236.176.52/tcp/4001/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z'
 
+describe('.bootstrap', () => {
   let peers
 
-  it('add returns an error when not passing an arg', (done) => {
-    return apiClients.a.bootstrap.add(null, (err) => {
-      expect(err).to.be.an.instanceof(Error)
-      done()
+  describe('.add', () => {
+    it('returns an error when called without args or options', (done) => {
+      return apiClients.a.bootstrap.add(null, (err) => {
+        expect(err).to.be.an.instanceof(Error)
+        done()
+      })
+    })
+
+    it('returns an error when called with an invalid arg', (done) => {
+      return apiClients.a.bootstrap.add(invalidArg, (err) => {
+        expect(err).to.be.an.instanceof(Error)
+        done()
+      })
+    })
+
+    it('returns a list of peers when called with a valid arg (ip4)', (done) => {
+      return apiClients.a.bootstrap.add(validIp4, (err, res) => {
+        expect(err).to.not.exist
+        expect(res).to.be.eql({ Peers: [validIp4] })
+        peers = res.Peers
+        expect(peers).to.exist
+        expect(peers.length).to.eql(1)
+        done()
+      })
     })
-  })
 
-  it('add returns an error when passing an invalid arg', (done) => {
-    return apiClients.a.bootstrap.add(invalidArg, (err) => {
-      expect(err).to.be.an.instanceof(Error)
-      done()
+    it('returns a list of default peers when called with the default option', (done) => {
+      return apiClients.a.bootstrap.add(null, { default: true }, (err, res) => {
+        expect(err).to.not.exist
+        peers = res.Peers
+        expect(peers).to.exist
+        expect(peers.length).to.above(1)
+        done()
+      })
     })
   })
 
-  it('add returns an error when passing an empty arg', (done) => {
-    return apiClients.a.bootstrap.add(emptyArg, (err) => {
-      expect(err).to.be.an.instanceof(Error)
-      done()
+  describe('.list', () => {
+    it('returns a list of peers', (done) => {
+      return apiClients.a.bootstrap.list(null, (err, res) => {
+        expect(err).to.not.exist
+        peers = res.Peers
+        expect(peers).to.exist
+        done()
+      })
     })
   })
 
-  it('adds a valid address (ip4)', (done) => {
-    return apiClients.a.bootstrap.add(validIp4, (err, res) => {
-      expect(err).to.not.exist
-      expect(res).to.be.eql({ Peers: [validIp4] })
-      peers = res.Peers
-      expect(peers).to.exist
-      expect(peers.length).to.eql(1)
-      done()
+  describe('.rm', () => {
+    it('returns an error when called with an invalid arg', (done) => {
+      return apiClients.a.bootstrap.rm(invalidArg, (err) => {
+        expect(err).to.be.an.instanceof(Error)
+        done()
+      })
+    })
+
+    it('returns empty list when called without an arg or options', (done) => {
+      return apiClients.a.bootstrap.rm(null, (err, res) => {
+        expect(err).to.not.exist
+        peers = res.Peers
+        expect(peers).to.exist
+        expect(peers.length).to.eql(0)
+        done()
+      })
+    })
+
+    it('returns list containing the peer removed when called with a valid arg (ip4)', (done) => {
+      return apiClients.a.bootstrap.rm(null, (err, res) => {
+        expect(err).to.not.exist
+        peers = res.Peers
+        expect(peers).to.exist
+        expect(peers.length).to.eql(0)
+        done()
+      })
+    })
+
+    it('returns list of all peers removed when all option is passed', (done) => {
+      return apiClients.a.bootstrap.rm(null, { all: true }, (err, res) => {
+        expect(err).to.not.exist
+        peers = res.Peers
+        expect(peers).to.exist
+        done()
+      })
     })
   })
 
-  it('add returns a list of default peers when default arg passed', (done) => {
-    return apiClients.a.bootstrap.add(null, { default: true }, (err, res) => {
-      expect(err).to.not.exist
-      peers = res.Peers
-      expect(peers).to.exist
-      done()
+  describe('.promise', () => {
+    describe('.add', () => {
+      it('returns an error when called without args or options', (done) => {
+        return apiClients.a.bootstrap.add(null)
+          .catch((err) => {
+            expect(err).to.be.an.instanceof(Error)
+            done()
+          })
+      })
+
+      it('returns an error when called with an invalid arg', (done) => {
+        return apiClients.a.bootstrap.add(invalidArg)
+          .catch((err) => {
+            expect(err).to.be.an.instanceof(Error)
+            done()
+          })
+      })
+
+      it('returns a list of peers when called with a valid arg (ip4)', (done) => {
+        return apiClients.a.bootstrap.add(validIp4)
+          .then((res) => {
+            expect(res).to.be.eql({ Peers: [validIp4] })
+            peers = res.Peers
+            expect(peers).to.exist
+            expect(peers.length).to.eql(1)
+            done()
+          })
+      })
+
+      it('returns a list of default peers when called with the default option', (done) => {
+        return apiClients.a.bootstrap.add(null, { default: true })
+          .then((res) => {
+            peers = res.Peers
+            expect(peers).to.exist
+            expect(peers.length).to.above(1)
+            done()
+          })
+      })
+    })
+
+    describe('.list', () => {
+      it('returns a list of peers', (done) => {
+        return apiClients.a.bootstrap.list(null)
+          .then((res) => {
+            peers = res.Peers
+            expect(peers).to.exist
+            done()
+          })
+      })
+    })
+
+    describe('.rm', () => {
+      it('returns an error when called with an invalid arg', (done) => {
+        return apiClients.a.bootstrap.rm(invalidArg)
+          .catch((err) => {
+            expect(err).to.be.an.instanceof(Error)
+            done()
+          })
+      })
+
+      it('returns empty list when called without an arg or options', (done) => {
+        return apiClients.a.bootstrap.rm(null)
+          .then((res) => {
+            peers = res.Peers
+            expect(peers).to.exist
+            expect(peers.length).to.eql(0)
+            done()
+          })
+      })
+
+      it('returns list containing the peer removed when called with a valid arg (ip4)', (done) => {
+        return apiClients.a.bootstrap.rm(null)
+          .then((res) => {
+            peers = res.Peers
+            expect(peers).to.exist
+            expect(peers.length).to.eql(0)
+            done()
+          })
+      })
+
+      it('returns list of all peers removed when all option is passed', (done) => {
+        return apiClients.a.bootstrap.rm(null, { all: true })
+          .then((res) => {
+            peers = res.Peers
+            expect(peers).to.exist
+            done()
+          })
+      })
     })
   })
 })