test: add interface-core-api ping tests and fix impl

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>

Author: alanshaw

src/ping-readable-stream.js

@@ -21,8 +21,7 @@ module.exports = (arg) => {
     const response = new PingMessageStream()
 
     send(request, (err, stream) => {
-      if (err) { return response.destroy(err) }
-
+      if (err) { return response.emit('error', err) }
       pump(stream, response)
     })
 

src/ping.js

@@ -2,7 +2,7 @@
 
 const promisify = require('promisify-es6')
 const pump = require('pump')
-const concat = require('concat-stream')
+const Writable = require('readable-stream').Writable
 const moduleConfig = require('./utils/module-config')
 const PingMessageStream = require('./utils/ping-message-stream')
 
@@ -31,16 +31,22 @@ module.exports = (arg) => {
     }
 
     // Transform the response stream to a value:
-    // [{ Success: <boolean>, Time: <number>, Text: <string> }]
+    // [{ success: <boolean>, time: <number>, text: <string> }]
     const transform = (stream, callback) => {
       const messageConverter = new PingMessageStream()
+      const responses = []
+
       pump(
         stream,
         messageConverter,
-        concat({encoding: 'object'}, (data) => callback(null, data)),
-        (err) => {
-          if (err) callback(err)
-        }
+        new Writable({
+          objectMode: true,
+          write (chunk, enc, cb) {
+            responses.push(chunk)
+            cb()
+          }
+        }),
+        (err) => callback(err, responses)
       )
     }
 

src/utils/ping-message-stream.js

@@ -13,6 +13,10 @@ class PingMessageStream extends TransformStream {
     try {
       const msg = pingMessageConverter(obj)
       this.push(msg)
+
+      if (!msg.success) {
+        throw new Error(msg.text)
+      }
     } catch (err) {
       return callback(err)
     }

test/interface/ping.spec.js

@@ -0,0 +1,32 @@
+/* eslint-env mocha */
+/* eslint max-nested-callbacks: ["error", 8] */
+'use strict'
+
+const test = require('interface-ipfs-core')
+const parallel = require('async/parallel')
+
+const IPFSApi = require('../../src')
+const f = require('../utils/factory')
+
+const nodes = []
+const common = {
+  setup: function (callback) {
+    callback(null, {
+      spawnNode: (cb) => {
+        f.spawn({ initOptions: { bits: 1024 } }, (err, _ipfsd) => {
+          if (err) {
+            return cb(err)
+          }
+
+          nodes.push(_ipfsd)
+          cb(null, IPFSApi(_ipfsd.apiAddr))
+        })
+      }
+    })
+  },
+  teardown: function (callback) {
+    parallel(nodes.map((node) => (cb) => node.stop(cb)), callback)
+  }
+}
+
+test.ping(common)