Skip to content

Commit 3e8f705

Browse files
authored
Merge pull request #22 from nipe0324/require-faraday-v1-or-v2
Require Faraday v2
2 parents 54ec806 + 688bab4 commit 3e8f705

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
## Unreleased
22

3+
- Require Faraday v2
4+
35
## v1.4.0
46

57
- Migrate CI/CD platform from Travis CI to GitHub Actions
6-
- Requires Ruby 3.0.0 or higher
8+
- Require Ruby 3.0.0 or higher
79

810
## v1.3.5
911

lib/qiita.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
require "active_support/core_ext/string/inflections"
33
require "active_support/core_ext/string/strip"
44
require "faraday"
5-
require "faraday_middleware"
65
require "json"
76
require "rack/utils"
87
require "rainbow"

qiita.gemspec

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ Gem::Specification.new do |spec|
1616
spec.require_paths = ["lib"]
1717

1818
spec.add_dependency "activesupport"
19-
spec.add_dependency "faraday", "~> 0.9"
20-
spec.add_dependency "faraday_middleware"
19+
spec.add_dependency 'faraday', '>= 2', '< 3'
2120
spec.add_dependency "rack"
2221
spec.add_dependency "rainbow"
2322
spec.add_dependency "rouge"
@@ -27,5 +26,5 @@ Gem::Specification.new do |spec|
2726
spec.add_development_dependency "pry"
2827
spec.add_development_dependency "rake"
2928
spec.add_development_dependency "rspec"
30-
spec.add_development_dependency "webmock", "1.20.4"
29+
spec.add_development_dependency "webmock"
3130
end

spec/qiita/client_spec.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,10 @@ def stub_api_request
341341
204
342342
end
343343

344+
let(:response_hash) do
345+
nil
346+
end
347+
344348
include_examples "valid condition"
345349
include_examples "sends request with JSON-encoded body"
346350
end
@@ -362,6 +366,10 @@ def stub_api_request
362366
204
363367
end
364368

369+
let(:response_hash) do
370+
nil
371+
end
372+
365373
include_examples "valid condition"
366374
include_examples "sends request with URL query"
367375
end

0 commit comments

Comments
 (0)