Skip to content

Commit 51be1b4

Browse files
committed
Rename option 'config' to 'credential'
1 parent 5b058e6 commit 51be1b4

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

src/lib/config.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,27 +57,27 @@ jest.mock("node:fs/promises", () => {
5757
});
5858

5959
describe("config", () => {
60-
describe("#getConfigDir", () => {
60+
describe("#getCredentialDir", () => {
6161
beforeEach(() => {
6262
config.load({});
6363
});
6464

6565
it("returns default path", () => {
66-
expect(config.getConfigDir()).toEqual(
66+
expect(config.getCredentialDir()).toEqual(
6767
"/home/test-user/.config/qiita-cli"
6868
);
6969
});
7070

7171
describe("with options", () => {
7272
beforeEach(() => {
7373
config.load({
74-
configDir: "my-config",
74+
credentialDir: "my-credential",
7575
});
7676
});
7777

7878
it("returns customized path", () => {
79-
expect(config.getConfigDir()).toEqual(
80-
"/home/test-user/qiita-articles/my-config"
79+
expect(config.getCredentialDir()).toEqual(
80+
"/home/test-user/qiita-articles/my-credential"
8181
);
8282
});
8383
});

src/lib/config.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,40 +5,40 @@ import process from "node:process";
55
import { configDebugger } from "./debugger";
66

77
interface Options {
8-
configDir?: string;
8+
credentialDir?: string;
99
profile?: string;
1010
itemsRootDir?: string;
1111
}
1212

1313
class Config {
14-
private configDir?: string;
14+
private credentialDir?: string;
1515
private itemsRootDir?: string;
1616
private credential?: Credential;
1717

1818
constructor() {}
1919

2020
load(options: Options) {
21-
this.configDir = this.resolveConfigDir(options.configDir);
21+
this.credentialDir = this.resolveConfigDir(options.credentialDir);
2222
this.itemsRootDir = this.resolveItemsRootDir(options.itemsRootDir);
2323
this.credential = new Credential({
24-
credentialDir: this.configDir,
24+
credentialDir: this.credentialDir,
2525
profile: options.profile,
2626
});
2727

2828
configDebugger(
2929
"load",
3030
JSON.stringify({
31-
configDir: this.configDir,
31+
credentialDir: this.credentialDir,
3232
itemsRootDir: this.itemsRootDir,
3333
})
3434
);
3535
}
3636

37-
getConfigDir() {
38-
if (!this.configDir) {
39-
throw new Error("configDir is undefined");
37+
getCredentialDir() {
38+
if (!this.credentialDir) {
39+
throw new Error("credentialDir is undefined");
4040
}
41-
return this.configDir;
41+
return this.credentialDir;
4242
}
4343

4444
// TODO: filesystemrepo 側にあるべきか確認
@@ -63,19 +63,19 @@ class Config {
6363
return this.credential.setCredential(credential);
6464
}
6565

66-
private resolveConfigDir(configDirPath?: string) {
66+
private resolveConfigDir(credentialDirPath?: string) {
6767
const packageName = "qiita-cli";
6868

6969
if (process.env.XDG_CONFIG_HOME) {
70-
const configDir = process.env.XDG_CONFIG_HOME;
71-
return path.join(configDir, packageName);
70+
const credentialDir = process.env.XDG_CONFIG_HOME;
71+
return path.join(credentialDir, packageName);
7272
}
73-
if (!configDirPath) {
73+
if (!credentialDirPath) {
7474
const homeDir = os.homedir();
7575
return path.join(homeDir, ".config", packageName);
7676
}
7777

78-
return this.resolveFullPath(configDirPath);
78+
return this.resolveFullPath(credentialDirPath);
7979
}
8080

8181
private resolveItemsRootDir(dirPath?: string) {

src/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ dotenv.config();
1111

1212
const args = arg(
1313
{
14-
"--config": String,
14+
"--credential": String,
1515
"--profile": String,
1616
"--root": String,
1717
"--verbose": Boolean,
@@ -29,7 +29,7 @@ if (args["--verbose"]) {
2929
}
3030

3131
config.load({
32-
configDir: args["--config"],
32+
credentialDir: args["--credential"],
3333
profile: args["--profile"],
3434
itemsRootDir: args["--root"],
3535
});

0 commit comments

Comments
 (0)