Revert "Remove always-false check"

iluuu1994 · iluuu1994 · commit cc4951e089ef · 2023-07-04T10:25:08.000+02:00
This reverts commit 45c93c1.
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
@@ -421,9 +421,7 @@ static HashTable* dom_get_debug_info_helper(zend_object *object, int *is_temp) /
 	ZEND_HASH_MAP_FOREACH_STR_KEY_PTR(prop_handlers, string_key, entry) {
 		zval value;
 
-		ZEND_ASSERT(string_key != NULL);
-
-		if (entry->read_func(obj, &value) == FAILURE) {
+		if (entry->read_func(obj, &value) == FAILURE || !string_key) {
 			continue;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -421,9 +421,7 @@ static HashTable* dom_get_debug_info_helper(zend_object object, int is_temp) /`
`421`	`421`	`ZEND_HASH_MAP_FOREACH_STR_KEY_PTR(prop_handlers, string_key, entry) {`
`422`	`422`	`zval value;`
`423`	`423`
`424`		`- ZEND_ASSERT(string_key != NULL);`
`425`		`-`
`426`		`- if (entry->read_func(obj, &value) == FAILURE) {`
	`424`	`+ if (entry->read_func(obj, &value) == FAILURE \|\| !string_key) {`
`427`	`425`	`continue;`
`428`	`426`	`}`
`429`	`427`