remove double close(fd)

iamacarpet · iamacarpet · commit 7e23285cbaeb · 2024-12-02T16:04:58.000Z
diff --git a/ext/opcache/zend_file_cache.c b/ext/opcache/zend_file_cache.c
@@ -1882,8 +1882,6 @@ bool zend_file_cache_script_validate(zend_file_handle *file_handle)
 	}
 
 	zend_arena_release(&CG(arena), checkpoint);
-    zend_file_cache_flock(fd, LOCK_UN);
-    close(fd);
     efree(filename);
     return true; // Validation successful
 
@@ -1900,7 +1898,6 @@ bool zend_file_cache_script_validate(zend_file_handle *file_handle)
     return false; // Validation failed
 }
 
-
 zend_persistent_script *zend_file_cache_script_load(zend_file_handle *file_handle)
 {
 	zend_string *full_path = file_handle->opened_path;

Original file line number	Diff line number	Diff line change
`@@ -1882,8 +1882,6 @@ bool zend_file_cache_script_validate(zend_file_handle *file_handle)`
`1882`	`1882`	`}`
`1883`	`1883`
`1884`	`1884`	`zend_arena_release(&CG(arena), checkpoint);`
`1885`		`- zend_file_cache_flock(fd, LOCK_UN);`
`1886`		`- close(fd);`
`1887`	`1885`	`efree(filename);`
`1888`	`1886`	`return true; // Validation successful`
`1889`	`1887`
`@@ -1900,7 +1898,6 @@ bool zend_file_cache_script_validate(zend_file_handle *file_handle)`
`1900`	`1898`	`return false; // Validation failed`
`1901`	`1899`	`}`
`1902`	`1900`
`1903`		`-`
`1904`	`1901`	`zend_persistent_script zend_file_cache_script_load(zend_file_handle file_handle)`
`1905`	`1902`	`{`
`1906`	`1903`	`zend_string *full_path = file_handle->opened_path;`