temp buf for msrv

Author: JPDye

src/client/legacy/connect/proxy/socks/mod.rs

@@ -41,13 +41,11 @@ where
     T: Read + Unpin,
     M: for<'a> TryFrom<&'a mut BytesMut, Error = ParsingError>,
 {
+    let mut tmp = [0; 513];
+
     loop {
-        let n = unsafe {
-            let spare = &mut *(buf.spare_capacity_mut() as *mut _ as *mut [u8]);
-            let n = crate::rt::read(&mut conn, spare).await?;
-            buf.set_len(buf.len() + n);
-            n
-        };
+        let n = crate::rt::read(&mut conn, &mut tmp).await?;
+        buf.extend_from_slice(&tmp[..n]);
 
         match M::try_from(buf) {
             Err(ParsingError::Incomplete) => {

src/client/legacy/connect/proxy/socks/v4/mod.rs

@@ -18,7 +18,11 @@ use bytes::BytesMut;
 
 use pin_project_lite::pin_project;
 
-/// TODO
+/// Tunnel Proxy via SOCKSv4
+///
+/// This is a connector that can be used by the `legacy::Client`. It wraps
+/// another connector, and after getting an underlying connection, it established
+/// a TCP tunnel over it using SOCKSv4.
 #[derive(Debug, Clone)]
 pub struct SocksV4<C> {
     inner: C,

src/client/legacy/connect/proxy/socks/v5/mod.rs

@@ -18,7 +18,11 @@ use bytes::BytesMut;
 
 use pin_project_lite::pin_project;
 
-/// TODO
+/// Tunnel Proxy via SOCKSv5
+///
+/// This is a connector that can be used by the `legacy::Client`. It wraps
+/// another connector, and after getting an underlying connection, it established
+/// a TCP tunnel over it using SOCKSv5.
 #[derive(Debug, Clone)]
 pub struct SocksV5<C> {
     inner: C,
@@ -154,8 +158,8 @@ impl SocksConfig {
             AuthMethod::NoAuth
         };
 
-        let mut recv_buf = BytesMut::with_capacity(1024);
-        let mut send_buf = BytesMut::with_capacity(1024);
+        let mut recv_buf = BytesMut::with_capacity(513); // Max length of valid recievable message is 513 from Auth Request
+        let mut send_buf = BytesMut::with_capacity(262); // Max length of valid sendable message is 262 from Auth Response
         let mut state = State::SendingNegReq;
 
         loop {

tests/proxy.rs

@@ -360,8 +360,6 @@ async fn test_socks_v4_works() {
         let conn = connector.call(target_dst).await.expect("tunnel");
         let mut tcp = conn.into_inner();
 
-        // TODO: broken here.
-
         tcp.write_all(b"Hello World!").await.expect("write 1");
 
         let mut buf = [0u8; 64];