Skip to content

Fixes torch.compile() compatible training #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

steverhoades
Copy link
Contributor

What does this PR do?

Fixes torch.compile() compatible training for the Advanced Dreambooth LoRa trainer.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator

DN6 commented Jan 16, 2024

cc: @linoytsaban for visibility.

@linoytsaban linoytsaban self-assigned this Jan 16, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
@sayakpaul wdyt? since you reviewed the previous linked pr #6566 :)

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tight. Thank you!

@sayakpaul
Copy link
Member

Let's get the conflicts resolved and ship this 🚀

@steverhoades steverhoades force-pushed the fix_torch_compile_advanced_sdxl_training branch from 6d581b3 to 6a98adf Compare January 16, 2024 17:05
@steverhoades
Copy link
Contributor Author

Let's get the conflicts resolved and ship this 🚀

Resolved.

@sayakpaul sayakpaul merged commit dce0668 into huggingface:main Jan 17, 2024
@sayakpaul
Copy link
Member

Thank you!

AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants