[#487] Fix assert on non sorted collections

Unless the entities define it, we cannot rely on the
element order to check the content of a collection.

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/EagerElementCollectionForBasicTypeListTest.java

@@ -9,7 +9,6 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.concurrent.CompletionStage;
-import java.util.stream.Collectors;
 import javax.persistence.ElementCollection;
 import javax.persistence.Entity;
 import javax.persistence.FetchType;
@@ -26,7 +25,8 @@
 
 import io.smallrye.mutiny.Uni;
 import io.vertx.ext.unit.TestContext;
-import org.assertj.core.api.Assertions;
+
+import static org.assertj.core.api.Assertions.assertThat;
 
 /**
  * Tests @{@link ElementCollection} on a {@link List} of basic types.
@@ -602,21 +602,9 @@ private Uni<List<Object>> selectFromPhonesWithMutiny(Person person) {
 				.getResultList();
 	}
 
-	/**
-	 * Utility method to check the content of the collection of elements.
-	 * It sorts the expected and actual phones before comparing.
-	 */
 	private static void assertPhones(TestContext context, Person person, String... expectedPhones) {
 		context.assertNotNull( person );
-		String[] sortedExpected = Arrays.stream( expectedPhones ).sorted()
-				.sorted( String.CASE_INSENSITIVE_ORDER )
-				.collect( Collectors.toList() )
-				.toArray( new String[expectedPhones.length] );
-		List<String> sortedActual = person.getPhones().stream()
-				.sorted( String.CASE_INSENSITIVE_ORDER )
-				.collect( Collectors.toList() );
-		Assertions.assertThat( sortedActual )
-				.containsExactly( sortedExpected );
+		assertThat( person.getPhones() ).containsExactlyInAnyOrder( expectedPhones );
 	}
 
 	@Entity(name = "Person")

hibernate-reactive-core/src/test/java/org/hibernate/reactive/EagerElementCollectionForEmbeddableTypeListTest.java

@@ -10,6 +10,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.concurrent.CompletionStage;
+import java.util.stream.Collectors;
 import javax.persistence.ElementCollection;
 import javax.persistence.Embeddable;
 import javax.persistence.Entity;
@@ -27,6 +28,8 @@
 import io.smallrye.mutiny.Uni;
 import io.vertx.ext.unit.TestContext;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 /**
  * Tests @{@link ElementCollection} on a {@link java.util.Set} of basic types.
  * <p>
@@ -689,10 +692,11 @@ private Uni<List<Object>> selectFromPhonesWithMutiny(Person person) {
 
 	private static void assertPhones(TestContext context, Person person, String... phones) {
 		context.assertNotNull( person );
-		context.assertEquals( phones.length, person.getPhones().size() );
-		for (int i=0; i<phones.length; i++) {
-			context.assertEquals( phones[i], person.getPhones().get(i).getNumber() );
-		}
+		context.assertNotNull( person.getPhones() );
+		List<String> personPhones = person.getPhones()
+				.stream().map( phone -> phone.getNumber() ).collect( Collectors.toList() );
+
+		assertThat( personPhones ).containsExactlyInAnyOrder( phones );
 	}
 
 	@Entity(name = "Person")