Remove warnings from tests

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/EagerElementCollectionForBasicTypeSetTest.java

@@ -442,7 +442,7 @@ private static void assertPhones(VertxTestContext context, Person person, String
 		assertNotNull( person );
 		String[] sortedExpected = Arrays.stream( expectedPhones ).sorted()
 				.sorted( String.CASE_INSENSITIVE_ORDER )
-				.collect( Collectors.toList() )
+				.toList()
 				.toArray( new String[expectedPhones.length] );
 		List<String> sortedActual = person.getPhones().stream()
 				.sorted( String.CASE_INSENSITIVE_ORDER )

hibernate-reactive-core/src/test/java/org/hibernate/reactive/IdentityGenerationWithBatchingTest.java

@@ -63,7 +63,7 @@ public void test(VertxTestContext context) {
 	}
 
 	private Book[] asBooks(String[] titles) {
-		return Arrays.asList( titles ).stream().map( Book::new ).toArray( Book[]::new );
+		return Arrays.stream( titles ).map( Book::new ).toArray( Book[]::new );
 	}
 
 	@Entity(name = "Book")

hibernate-reactive-core/src/test/java/org/hibernate/reactive/IdentityGeneratorDynamicInsertTest.java

@@ -70,7 +70,7 @@ private CompletionStage<?> populateDb() {
 		return getSessionFactory()
 				.withTransaction( (session, tx) -> session.persist( identities.toArray() ) )
 				.thenAccept( ignore -> {
-					Long assignedId = 0L;
+					long assignedId = 0L;
 					for ( EntityWithIdentity identity : identities ) {
 						assertNotNull( identity.id );
 						assertTrue( identity.id > assignedId );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/IdentityGeneratorTest.java

@@ -68,7 +68,7 @@ private CompletionStage<?> populateDb() {
 		return getSessionFactory()
 				.withTransaction( (session, tx) -> session.persist( identities.toArray() ) )
 				.thenAccept( ignore -> {
-					Long assignedId = 0L;
+					long assignedId = 0L;
 					for ( EntityWithIdentity identity : identities ) {
 						assertNotNull( identity.id );
 						assertTrue( identity.id > assignedId );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/IdentityGeneratorWithColumnTransformerTest.java

@@ -72,7 +72,7 @@ private CompletionStage<?> populateDb() {
 		return getSessionFactory()
 				.withTransaction( (session, tx) -> session.persist( identities.toArray() ) )
 				.thenAccept( ignore -> {
-					Long assignedId = 0L;
+					long assignedId = 0L;
 					for ( EntityWithIdentity identity : identities ) {
 						assertNotNull( identity.id );
 						assertTrue( identity.id > assignedId );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyInitializationExceptionTest.java

@@ -72,10 +72,14 @@ public void testLazyInitializationExceptionWithMutiny(VertxTestContext context)
 
 	@Test
 	public void testLazyInitializationExceptionWithStage(VertxTestContext context) {
-		test( context, assertThrown( LazyInitializationException.class, openSession()
-				.thenCompose( ss -> ss.createSelectionQuery( "from Artist", Artist.class ).getSingleResult() )
-				.thenAccept( artist -> artist.getPaintings().size() ) )
-				.thenAccept( LazyInitializationExceptionTest::assertLazyInitialization )
+		test(
+				context, assertThrown(
+						LazyInitializationException.class, openSession()
+								.thenCompose( ss -> ss
+										.createSelectionQuery( "from Artist", Artist.class )
+										.getSingleResult() )
+								.thenAccept( artist -> artist.getPaintings().size() )
+				).thenAccept( LazyInitializationExceptionTest::assertLazyInitialization )
 		);
 	}
 

hibernate-reactive-core/src/test/java/org/hibernate/reactive/MultithreadedInsertionTest.java

@@ -37,6 +37,7 @@
 import jakarta.persistence.Table;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
+import static org.assertj.core.api.Assertions.fail;
 import static org.hibernate.cfg.AvailableSettings.SHOW_SQL;
 import static org.hibernate.reactive.BaseReactiveTest.setDefaultProperties;
 import static org.hibernate.reactive.provider.Settings.POOL_CONNECT_TIMEOUT;
@@ -233,11 +234,16 @@ public void reached() {
 
 		public void waitForEveryone() {
 			try {
-				countDownLatch.await( TIMEOUT_MINUTES, TimeUnit.MINUTES );
-				prettyOut( "Everyone has now breached '" + label + "'" );
+				boolean reachedZero = countDownLatch.await( TIMEOUT_MINUTES, MINUTES );
+				if ( reachedZero ) {
+					prettyOut( "Everyone has now breached '" + label + "'" );
+				}
+				else {
+					fail( "Time out reached" );
+				}
 			}
 			catch ( InterruptedException e ) {
-				e.printStackTrace();
+				fail( e );
 			}
 		}
 	}

hibernate-reactive-core/src/test/java/org/hibernate/reactive/OneToManyArrayMergeTest.java

@@ -111,9 +111,7 @@ public User(Long id, String firstname, String lastname, Role... roles) {
 			this.firstname = firstname;
 			this.lastname = lastname;
 			this.roles = new Role[roles.length];
-			for ( int i = 0; i < roles.length; i++ ) {
-				this.roles[i] = roles[i];
-			}
+			System.arraycopy( roles, 0, this.roles, 0, roles.length );
 		}
 
 		public Long getId() {

hibernate-reactive-core/src/test/java/org/hibernate/reactive/OneToManyTest.java

@@ -45,9 +45,6 @@ public void testPersistAll(VertxTestContext context) {
 		Author author = new Author( "Iain M Banks" );
 		author.books.add( book1 );
 		author.books.add( book2 );
-		final Book[] bookArray = new Book[2];
-		bookArray[0] = book1;
-		bookArray[1] = book2;
 
 		test( context, getMutinySessionFactory()
 				.withTransaction( session -> session.persistAll( book1, book2, author ) )
@@ -67,9 +64,6 @@ public void testFetchJoinQueryGetSingleResult(VertxTestContext context) {
 		Author author = new Author( "Iain M Banks" );
 		author.books.add( book1 );
 		author.books.add( book2 );
-		final Book[] bookArray = new Book[2];
-		bookArray[0] = book1;
-		bookArray[1] = book2;
 
 		test( context, getMutinySessionFactory()
 				.withTransaction( session -> session.persistAll( book1, book2, author ) )

hibernate-reactive-core/src/test/java/org/hibernate/reactive/QueryTest.java

@@ -138,7 +138,7 @@ public void testCriteriaEntityQuery(VertxTestContext context) {
 		update.set( b.get( "title" ), "XXX" );
 
 		CriteriaDelete<Book> delete = builder.createCriteriaDelete( Book.class );
-		b = delete.from( Book.class );
+		delete.from( Book.class );
 
 		test(
 				context,

hibernate-reactive-core/src/test/java/org/hibernate/reactive/SoftDeleteTest.java

@@ -172,7 +172,7 @@ private void testSoftDelete(
 						} )
 				)
 				// Delete an entity
-				.call( deleteEntity::get )
+				.call( deleteEntity )
 				// Test select all
 				.call( () -> getMutinySessionFactory().withTransaction( s -> s
 						.createSelectionQuery( "from " + entityClass.getSimpleName() + " order by id", Object.class )