Skip to content

Commit 893e9e4

Browse files
committed
HHH-11536 - Fix unit tests failing on Oracle
1 parent 3dda9d7 commit 893e9e4

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

hibernate-core/src/test/java/org/hibernate/jpa/test/graphs/mapped_by_id/LoadGraphFindByIdTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import javax.persistence.Id;
1616
import javax.persistence.MapsId;
1717
import javax.persistence.OneToOne;
18+
import javax.persistence.Table;
1819
import javax.persistence.TypedQuery;
1920
import javax.persistence.criteria.CriteriaBuilder;
2021
import javax.persistence.criteria.CriteriaQuery;
@@ -111,7 +112,8 @@ public static class UserStatistic {
111112
private Integer commentCount;
112113
}
113114

114-
@Entity(name = "Users")
115+
@Entity(name = "User")
116+
@Table(name = "USERS")
115117
public static class User {
116118

117119
@Id

hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/cache/LazyInCacheTestTask.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import javax.persistence.GenerationType;
2525
import javax.persistence.Id;
2626
import javax.persistence.OneToMany;
27+
import javax.persistence.Table;
2728
import java.util.ArrayList;
2829
import java.util.List;
2930

@@ -66,7 +67,8 @@ public void execute() {
6667
protected void cleanup() {
6768
}
6869

69-
@Entity(name = "Orders")
70+
@Entity(name = "Order")
71+
@Table(name = "ORDERS")
7072
@Cache( usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE )
7173
public static class Order {
7274

hibernate-core/src/test/java/org/hibernate/test/hql/CoalesceTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import javax.persistence.GeneratedValue;
1313
import javax.persistence.Id;
1414

15+
import org.hibernate.dialect.Oracle8iDialect;
1516
import org.hibernate.dialect.PostgreSQL81Dialect;
1617
import org.hibernate.query.Query;
1718

@@ -64,6 +65,7 @@ public void HHH_10463_TestCoalesce() {
6465

6566
@Test
6667
@SkipForDialect( jiraKey = "HHH-10463", value = PostgreSQL81Dialect.class)
68+
@SkipForDialect( jiraKey = "HHH-10463", value = Oracle8iDialect.class)
6769
public void HHH_10463_NullInCoalesce() {
6870
doInHibernate( this::sessionFactory, session -> {
6971
Query query = session.createQuery("from Person p where p.name = coalesce(:name, p.name) ");

hibernate-core/src/test/java/org/hibernate/test/naturalid/inheritance/cache/ExtendedEntity.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88

99
import javax.persistence.Column;
1010
import javax.persistence.Entity;
11-
import javax.persistence.Table;
1211

1312
@Entity
14-
@Table
1513
public class ExtendedEntity extends MyEntity {
1614
public ExtendedEntity() {
1715
}

hibernate-core/src/test/java/org/hibernate/test/naturalid/inheritance/cache/MyEntity.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,13 @@
1111
import javax.persistence.Entity;
1212
import javax.persistence.GeneratedValue;
1313
import javax.persistence.Id;
14-
import javax.persistence.Table;
1514

1615
import org.hibernate.annotations.Cache;
1716
import org.hibernate.annotations.CacheConcurrencyStrategy;
1817
import org.hibernate.annotations.GenericGenerator;
1918
import org.hibernate.annotations.NaturalId;
2019

2120
@Entity
22-
@Table
2321
@Cacheable
2422
@Cache(usage = CacheConcurrencyStrategy.TRANSACTIONAL)
2523
public class MyEntity {
@@ -45,7 +43,7 @@ public void setId(Long id) {
4543
}
4644

4745
@NaturalId
48-
@Column
46+
@Column(name = "natural_id")
4947
public String getUid() {
5048
return uid;
5149
}

hibernate-core/src/test/java/org/hibernate/test/schemaupdate/foreignkeys/definition/ForeignKeyDefinitionSecondaryTableTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import javax.persistence.GeneratedValue;
1313
import javax.persistence.Id;
1414
import javax.persistence.SecondaryTable;
15+
import javax.persistence.Table;
1516

1617
import org.hibernate.dialect.H2Dialect;
1718

@@ -31,7 +32,8 @@ protected Class<?>[] getAnnotatedClasses() {
3132
};
3233
}
3334

34-
@Entity(name = "Users")
35+
@Entity(name = "User")
36+
@Table(name = "USERS")
3537
@SecondaryTable(name = "User_details", foreignKey = @ForeignKey(name = "secondary", foreignKeyDefinition = "foreign key /* FK */ (id) references Users"))
3638
public class User {
3739

0 commit comments

Comments
 (0)