HHH-11563 - Avoid calling multiple times org.hibernate.mapping.Component#getComponentClass() during the PojoComponentTuplizer creation

Author: dreab8

hibernate-core/src/main/java/org/hibernate/tuple/PojoInstantiator.java

@@ -50,7 +50,11 @@ public PojoInstantiator(
 	}
 
 	public PojoInstantiator(Component component, ReflectionOptimizer.InstantiationOptimizer optimizer) {
-		this.mappedClass = component.getComponentClass();
+		this( component.getComponentClass(), optimizer );
+	}
+
+	public PojoInstantiator(Class componentClass, ReflectionOptimizer.InstantiationOptimizer optimizer) {
+		this.mappedClass = componentClass;
 		this.isAbstract = ReflectHelper.isAbstractClass( mappedClass );
 		this.optimizer = optimizer;
 

hibernate-core/src/main/java/org/hibernate/tuple/component/AbstractComponentTuplizer.java

@@ -34,6 +34,7 @@ public abstract class AbstractComponentTuplizer implements ComponentTuplizer {
 	protected abstract Setter buildSetter(Component component, Property prop);
 
 	protected AbstractComponentTuplizer(Component component) {
+		setComponentClass( component );
 		propertySpan = component.getPropertySpan();
 		getters = new Getter[propertySpan];
 		setters = new Setter[propertySpan];
@@ -102,4 +103,8 @@ public void setParent(Object component, Object parent, SessionFactoryImplementor
 	public Getter getGetter(int i) {
 		return getters[i];
 	}
+
+	// It should be an abstract method but not sure if this can break any customer extension
+	protected void setComponentClass(Component component){
+	}
 }

hibernate-core/src/main/java/org/hibernate/tuple/component/PojoComponentTuplizer.java

@@ -22,7 +22,6 @@
 import org.hibernate.property.access.spi.Getter;
 import org.hibernate.property.access.spi.PropertyAccess;
 import org.hibernate.property.access.spi.Setter;
-import org.hibernate.service.ServiceRegistry;
 import org.hibernate.tuple.Instantiator;
 import org.hibernate.tuple.PojoInstantiator;
 
@@ -33,16 +32,14 @@
  * @author Steve Ebersole
  */
 public class PojoComponentTuplizer extends AbstractComponentTuplizer {
-	private final Class componentClass;
+	private Class componentClass;
 	private ReflectionOptimizer optimizer;
 	private final Getter parentGetter;
 	private final Setter parentSetter;
 
 	public PojoComponentTuplizer(Component component) {
 		super( component );
 
-		this.componentClass = component.getComponentClass();
-
 		String[] getterNames = new String[propertySpan];
 		String[] setterNames = new String[propertySpan];
 		Class[] propTypes = new Class[propertySpan];
@@ -58,8 +55,6 @@ public PojoComponentTuplizer(Component component) {
 			parentGetter = null;
 		}
 		else {
-			final ServiceRegistry serviceRegistry =
-					component.getMetadata().getMetadataBuildingOptions().getServiceRegistry();
 			final PropertyAccess propertyAccess = PropertyAccessStrategyBasicImpl.INSTANCE.buildPropertyAccess(
 					componentClass,
 					parentPropertyName
@@ -128,31 +123,36 @@ public void setParent(Object component, Object parent, SessionFactoryImplementor
 	}
 
 	protected Instantiator buildInstantiator(Component component) {
-		if ( component.isEmbedded() && ReflectHelper.isAbstractClass( component.getComponentClass() ) ) {
-			return new ProxiedInstantiator( component );
+		if ( component.isEmbedded() && ReflectHelper.isAbstractClass( this.componentClass ) ) {
+			return new ProxiedInstantiator( this.componentClass );
 		}
 		if ( optimizer == null ) {
-			return new PojoInstantiator( component, null );
+			return new PojoInstantiator( this.componentClass, null );
 		}
 		else {
-			return new PojoInstantiator( component, optimizer.getInstantiationOptimizer() );
+			return new PojoInstantiator( this.componentClass, optimizer.getInstantiationOptimizer() );
 		}
 	}
 
 	protected Getter buildGetter(Component component, Property prop) {
-		return prop.getGetter( component.getComponentClass() );
+		return prop.getGetter( this.componentClass );
 	}
 
 	protected Setter buildSetter(Component component, Property prop) {
-		return prop.getSetter( component.getComponentClass() );
+		return prop.getSetter( this.componentClass );
+	}
+
+	@Override
+	protected void setComponentClass(Component component) {
+		this.componentClass = component.getComponentClass();
 	}
 
 	private static class ProxiedInstantiator implements Instantiator {
 		private final Class proxiedClass;
 		private final BasicProxyFactory factory;
 
-		public ProxiedInstantiator(Component component) {
-			proxiedClass = component.getComponentClass();
+		public ProxiedInstantiator(Class componentClass) {
+			proxiedClass = componentClass;
 			if ( proxiedClass.isInterface() ) {
 				factory = Environment.getBytecodeProvider()
 						.getProxyFactoryFactory()