Skip to content

Commit e541907

Browse files
committed
fix: change to newly recommended tool instead of pep517.build
This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83
1 parent 3b9d2f4 commit e541907

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,14 @@ source, it is best to have Pip 10 on a manylinux1, macOS, or Windows system.
224224
You can then build the SDists, or run any procedure that makes SDists
225225
internally, like making wheels or installing. Since Pip itself
226226
does not have an `sdist` command (it does have `wheel` and `install`), you will
227-
need to use the `pep517` package directly:
227+
need to use the upcoming `build` package:
228228

229229
```bash
230230
# Normal package
231-
python3 -m pep517.build -s .
231+
python3 -m build -s .
232232

233233
# Global extra
234-
PYBIND11_GLOBAL_SDIST=1 python3 -m pep517.build -s .
234+
PYBIND11_GLOBAL_SDIST=1 python3 -m build -s .
235235
```
236236

237237
If you want to use the classic "direct" usage of `python setup.py`, you will
@@ -256,7 +256,7 @@ When you invoke any `setup.py` command from the source directory, including
256256
`pip wheel .` and `pip install .`, you will activate a full source build. This
257257
is made of the following steps:
258258

259-
1. If the tool is PEP 518 compliant, like `pep517.build` or Pip 10+, it will
259+
1. If the tool is PEP 518 compliant, like `build` or Pip 10+, it will
260260
create a temporary virtual environment and install the build requirements
261261
(mostly CMake) into it. (if you are not on Windows, macOS, or a manylinux
262262
compliant system, you can disable this with `--no-build-isolation` as long

.github/workflows/configure.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,15 @@ jobs:
120120
python-version: 3.8
121121

122122
- name: Prepare env
123-
run: python -m pip install -r tests/requirements.txt pep517 twine --prefer-binary
123+
run: python -m pip install -r tests/requirements.txt build twine --prefer-binary
124124

125125
- name: Python Packaging tests
126126
run: pytest tests/extra_python_package/
127127

128128
- name: Build SDist and wheels
129129
run: |
130-
python -m pep517.build -s -b .
131-
PYBIND11_GLOBAL_SDIST=1 python -m pep517.build -s -b .
130+
python -m build -s -w .
131+
PYBIND11_GLOBAL_SDIST=1 python -m build -s -w .
132132
133133
- name: Check metadata
134134
run: twine check dist/*

0 commit comments

Comments
 (0)