Skip to content

Commit cc8f636

Browse files
committed
fix: add missing single_metric example; test var name
1 parent 807671c commit cc8f636

File tree

2 files changed

+27
-24
lines changed

2 files changed

+27
-24
lines changed

python/example/hello_world/app.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ def lambda_handler(event, context):
5252
logger.error(e)
5353
raise e
5454

55+
with single_metric(name="UniqueMetricDimension", unit="Seconds", value=1) as metric:
56+
metric.add_dimension(name="unique_dimension", value="for_unique_metric")
57+
5558
logger.info("Returning message to the caller")
5659
return {
5760
"statusCode": 200,

python/tests/functional/test_metrics.py

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ def remove_timestamp(metrics: List):
8484

8585

8686
def test_single_metric(capsys, metric, dimension, namespace):
87-
with single_metric(**metric) as my_metrics:
88-
my_metrics.add_dimension(**dimension)
89-
my_metrics.add_namespace(**namespace)
87+
with single_metric(**metric) as my_metric:
88+
my_metric.add_dimension(**dimension)
89+
my_metric.add_namespace(**namespace)
9090

9191
output = json.loads(capsys.readouterr().out.strip())
9292
expected = serialize_single_metric(metric=metric, dimension=dimension, namespace=namespace)
@@ -96,11 +96,11 @@ def test_single_metric(capsys, metric, dimension, namespace):
9696

9797

9898
def test_single_metric_one_metric_only(capsys, metric, dimension, namespace):
99-
with single_metric(**metric) as my_metrics:
100-
my_metrics.add_metric(name="second_metric", unit="Count", value=1)
101-
my_metrics.add_metric(name="third_metric", unit="Seconds", value=1)
102-
my_metrics.add_dimension(**dimension)
103-
my_metrics.add_namespace(**namespace)
99+
with single_metric(**metric) as my_metric:
100+
my_metric.add_metric(name="second_metric", unit="Count", value=1)
101+
my_metric.add_metric(name="third_metric", unit="Seconds", value=1)
102+
my_metric.add_dimension(**dimension)
103+
my_metric.add_namespace(**namespace)
104104

105105
output = json.loads(capsys.readouterr().out.strip())
106106
expected = serialize_single_metric(metric=metric, dimension=dimension, namespace=namespace)
@@ -130,11 +130,11 @@ def test_multiple_namespaces(metric, dimension, namespace):
130130
namespace_b = {"name": "AnotherNamespace"}
131131

132132
with pytest.raises(UniqueNamespaceError):
133-
with single_metric(**metric) as m:
134-
m.add_dimension(**dimension)
135-
m.add_namespace(**namespace)
136-
m.add_namespace(**namespace_a)
137-
m.add_namespace(**namespace_b)
133+
with single_metric(**metric) as my_metric:
134+
my_metric.add_dimension(**dimension)
135+
my_metric.add_namespace(**namespace)
136+
my_metric.add_namespace(**namespace_a)
137+
my_metric.add_namespace(**namespace_b)
138138

139139

140140
def test_log_metrics(capsys, metrics, dimensions, namespace):
@@ -224,23 +224,23 @@ def test_incorrect_metric_unit(metric, dimension, namespace):
224224
metric["unit"] = "incorrect_unit"
225225

226226
with pytest.raises(MetricUnitError):
227-
with single_metric(**metric) as m:
228-
m.add_dimension(**dimension)
229-
m.add_namespace(**namespace)
227+
with single_metric(**metric) as my_metric:
228+
my_metric.add_dimension(**dimension)
229+
my_metric.add_namespace(**namespace)
230230

231231

232232
def test_schema_no_namespace(metric, dimension):
233233
with pytest.raises(SchemaValidationError):
234-
with single_metric(**metric) as m:
235-
m.add_dimension(**dimension)
234+
with single_metric(**metric) as my_metric:
235+
my_metric.add_dimension(**dimension)
236236

237237

238238
def test_schema_incorrect_value(metric, dimension, namespace):
239239
metric["value"] = "some_value"
240240
with pytest.raises(MetricValueError):
241-
with single_metric(**metric) as m:
242-
m.add_dimension(**dimension)
243-
m.add_namespace(**namespace)
241+
with single_metric(**metric) as my_metric:
242+
my_metric.add_dimension(**dimension)
243+
my_metric.add_namespace(**namespace)
244244

245245

246246
def test_schema_no_metrics(dimensions, namespace):
@@ -258,7 +258,7 @@ def test_exceed_number_of_dimensions(metric, namespace):
258258
dimensions.append({"name": f"test_{i}", "value": "test"})
259259

260260
with pytest.raises(SchemaValidationError):
261-
with single_metric(**metric) as m:
262-
m.add_namespace(**namespace)
261+
with single_metric(**metric) as my_metric:
262+
my_metric.add_namespace(**namespace)
263263
for dimension in dimensions:
264-
m.add_dimension(**dimension)
264+
my_metric.add_dimension(**dimension)

0 commit comments

Comments
 (0)