From c0a8085137c1ce8ed933e490e510608cf8ce36a9 Mon Sep 17 00:00:00 2001 From: jneira Date: Tue, 20 Apr 2021 22:38:32 +0200 Subject: [PATCH 1/5] Correct grammar --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6aa63c70..59f04bcf 100644 --- a/package.json +++ b/package.json @@ -223,7 +223,7 @@ "scope": "resource", "type": "string", "default": true, - "markdownDescription": "Features set used by wingman (tactic) plugin" + "markdownDescription": "Feature set used by wingman (tactic) plugin" }, "haskell.plugin.tactics.config.hole_severity": { "enumDescriptions": [ From bb6402415cb1c057f351666363b9aa651a4502ce Mon Sep 17 00:00:00 2001 From: jneira Date: Tue, 20 Apr 2021 22:39:38 +0200 Subject: [PATCH 2/5] Add changelog for 1.3.0 --- Changelog.md | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index 3d311cfd..355177a7 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,6 +1,23 @@ ### 1.3.0 -- Add `haskell.releasesURL` option to override where to look for HLS releases search for HLS downloads (@soiamsoNG) +- Add `haskell.releasesURL` option to override where to look for HLS releases search for HLS downloads (@soiamsoNG), thanks to @soiamsoNG +- With this version _the only supported lsp server variant is [`haskell-language-server`](https://github.com/haskell/haskell-language-server)_ +- Add support for generic plugin configuration. Thanks to it, each plugin capability (diagnostics, code actions, code lenses, etc) or the entire plugin can be disabled +- Add some plugin specic options: + - [wingman](https://haskellwingman.dev/) (aka tactics) plugin + - `haskell.plugin.tactic.config.features`: Feature set used by the plugin + - `haskell.plugin.tactics.config.hole_severity`: The severity to use when showing hole diagnostics + - `haskell.plugin.tactic.config.max_use_ctor_actions`: Maximum number of `Use constructor ` code actions that can appear + - `haskell.plugin.tactics.config.timeout_duration`: The timeout for Wingman actions, in seconds + - completions + - `haskell.plugin.ghcide-completions.config.autoExtendOn`: Extends the import list automatically when completing a out-of-scope identifier + - `haskell.plugin.ghcide-completions.config.snippetsOn`: Inserts snippets when using code completions + - type signature lenses - `haskell.plugin.ghcide-type-lenses.config.mode`: Control how type lenses are shown +- The option `haskell.serverExecutablePath` has now `machine` scope, so it can be only changed globally by the user. It avoids a potential security vulnerability as folders containing `.vscode/settings.json` with that option could execute arbitrary programs. +- Deprecated options: + - `haskell.hlintOn`: use `haskell.plugin.hlint.globalOn` instead. + - `haskell.completionSnippetsOn`: use `haskell.plugin.ghcide-completions.config.snippetsOn` +- Fixed a small typo that caused the server not to be loaded in `.lhs` files, thanks to @Max7cd ### 1.2.0 From ac4d2ced6b330caf38dcfa1a2d9fb844279b8da8 Mon Sep 17 00:00:00 2001 From: jneira Date: Tue, 20 Apr 2021 23:27:07 +0200 Subject: [PATCH 3/5] Correct max_use_ctor_actions default value --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 59f04bcf..02ebca63 100644 --- a/package.json +++ b/package.json @@ -249,7 +249,7 @@ "title": "Max number of constructors", "scope": "resource", "type": "integer", - "default": true, + "default": 5, "markdownDescription": "Maximum number of `Use constructor ` code actions that can appear" }, "haskell.plugin.tactics.config.timeout_duration": { From 78fb02eb9a8c6b5972f9a05ae0688d21cd9e7e85 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 21 Apr 2021 07:19:42 +0200 Subject: [PATCH 4/5] Remove mention to wingman old name Co-authored-by: Sandy Maguire --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 02ebca63..42c02ad4 100644 --- a/package.json +++ b/package.json @@ -223,7 +223,7 @@ "scope": "resource", "type": "string", "default": true, - "markdownDescription": "Feature set used by wingman (tactic) plugin" + "markdownDescription": "Feature set used by Wingman" }, "haskell.plugin.tactics.config.hole_severity": { "enumDescriptions": [ From d09dd055db4053ea343e58c0dc79367f9509fd45 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 21 Apr 2021 07:20:30 +0200 Subject: [PATCH 5/5] Remove redundant author mention --- Changelog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index 355177a7..fa7c73f3 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,6 +1,6 @@ ### 1.3.0 -- Add `haskell.releasesURL` option to override where to look for HLS releases search for HLS downloads (@soiamsoNG), thanks to @soiamsoNG +- Add `haskell.releasesURL` option to override where to look for HLS releases search for HLS downloads, thanks to @soiamsoNG - With this version _the only supported lsp server variant is [`haskell-language-server`](https://github.com/haskell/haskell-language-server)_ - Add support for generic plugin configuration. Thanks to it, each plugin capability (diagnostics, code actions, code lenses, etc) or the entire plugin can be disabled - Add some plugin specic options: