Skip to content

Prepare 0.8.0 release #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2021
Merged

Prepare 0.8.0 release #1149

merged 3 commits into from
Jan 3, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 2, 2021

  • I've changed the formatting, to fix markdownlint warnings

@jneira jneira requested review from pepeiborra, Ailrun and alanz January 2, 2021 22:43
@pepeiborra
Copy link
Collaborator

pepeiborra commented Jan 2, 2021

Because of the ghcide merge, this release also includes a bunch of ghcide fixes and improvements. I think it's probably worth listing those too. The relevant part of the git log is:

$ git log --pretty="* %s - (%an)" ghcide

* Fix extend imports regression (#769) - (Pepe Iborra)
* Perform memory measurement on SIGUSR1 (#761) - (Pepe Iborra)
* Tests for cradle retry - (Pepe Iborra)
* Make a test more reliable - (Pepe Iborra)
* On cradle failure, register the hie.yaml file as a dependency - (Pepe Iborra)
* Invert the dependency between hls-plugin-api and ghcide (#701) - (Pepe Iborra)
* Launch ghcide/HLS for tests with -j2 to limit amount of memory used - (Pepe Iborra)
* Move ghcide artifacts under /ghcide - (Pepe Iborra)
* Temporarily disable the upstream branch for benchmarks - (Pepe Iborra)
* Combine test and nix CI scripts - (Pepe Iborra)
* Add ghcide bench CI action - (Pepe Iborra)
* Delete redundant descriptors and scripts - (Pepe Iborra)
* Move under /ghcide folder - (Pepe Iborra)
* Prepare release 0.6.0.2 (haskell/ghcide#958) - (Pepe Iborra)
* Fix diagnostics update bug (haskell/ghcide#959) - (Pepe Iborra)
* Use qualified module name from diagnostics in suggestNewImport (haskell/ghcide#945) - (Potato Hatsue)
* Rescue stack windows build (haskell/ghcide#954) - (Pepe Iborra)
* Expose Documentation module (haskell/ghcide#956) - (Guru Devanla)
* Rename hie.yaml.* to hie-*.yaml (haskell/ghcide#953) - (Potato Hatsue)
* Deduplicate module not found diagnostics (haskell/ghcide#952) - (Pepe Iborra)
* Remove language extension completions. (haskell/ghcide#948) - (Guru Devanla)

If you are considering including a section on ghcide, I would recommend editing those items down to a short list:

* Retry a failed cradle if the cradle descriptor changes (#762) - (Pepe Iborra)
* Fix extend imports regression (#769) - (Pepe Iborra)
* Perform memory measurement on SIGUSR1 (#761) - (Pepe Iborra)
* Fix diagnostics update bug (haskell/ghcide#959) - (Pepe Iborra)
* Use qualified module name from diagnostics in suggestNewImport (haskell/ghcide#945) - (Potato Hatsue)
* Deduplicate module not found diagnostics (haskell/ghcide#952) - (Pepe Iborra)

@jneira
Copy link
Member Author

jneira commented Jan 3, 2021

@pepeiborra hi, thanks for the suggestion. However, some of those pr's are already included in the ghcide Changelog or in the actual list of merged pr's.
The unique i miss from both lists is haskell/ghcide#952, that was merged before ghcide-0.6.0.2 but no listed in the changelog for some reason. It seems its place would be the ghcide Changelog.

My idea was list all pr's without mention the subpackage (ghcide, hls-plugin-api, plugins), cause it would make generate the Changelog a little bit more laborious. Now it is simply matter of run cabal run GenChangeLog.hs and paste the output in ChangeLog.md

@jneira
Copy link
Member Author

jneira commented Jan 3, 2021

btw, we should replace the links to pr's in the ghcide changelog using # shorthand with full links to the ghcide repo (in another pr if you dont mind)

@jneira jneira merged commit 6b0740c into haskell:master Jan 3, 2021
@jneira
Copy link
Member Author

jneira commented Jan 3, 2021

A release of hls-plugin-api is needed, will do asap

@pepeiborra
Copy link
Collaborator

@pepeiborra hi, thanks for the suggestion. However, some of those pr's are already included in the ghcide Changelog or in the actual list of merged pr's.

The unique i miss from both lists is haskell/ghcide#952, that was merged before ghcide-0.6.0.2 but no listed in the changelog for some reason. It seems its place would be the ghcide Changelog.

My idea was list all pr's without mention the subpackage (ghcide, hls-plugin-api, plugins), cause it would make generate the Changelog a little bit more laborious. Now it is simply matter of run cabal run GenChangeLog.hs and paste the output in ChangeLog.md

What is missing is the usual "upgrading to ghcide vX.X.X" referencing a ghcide change log

@jneira
Copy link
Member Author

jneira commented Jan 3, 2021

In fact all version bumps are missing, i'll do a new pr with that change (i will add the ref to ghcide in the changelog too)

@jneira jneira deleted the prepare-0.8.0 branch January 3, 2021 09:48
@pepeiborra
Copy link
Collaborator

But there is no corresponding ghcide version that you can reference? You will need to do a ghcide release too

@jneira
Copy link
Member Author

jneira commented Jan 3, 2021

@pepeiborra yeah, thanks for remind me it, there are breaking changes after 0.6.0.2
so i will bump ghcide version in that pr to 0.7.0, could you make the hackage release (afaik i have not hackage perm to do it)

@pepeiborra
Copy link
Collaborator

You do now: http://hackage.haskell.org/package/ghcide/maintainers/

@jneira jneira mentioned this pull request Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants