Dispatch TODOs, amend remaining TODOs as future work

Author: dylan-thinnes

ghcide/session-loader/Development/IDE/Session.hs

@@ -924,7 +924,6 @@ newComponentCache recorder exts cradlePath _cfp hsc_env old_cis new_cis dir = do
 
 #if MIN_VERSION_ghc(9,6,1)
     let closure_errs = maybeToList $ checkHomeUnitsClosed' (hsc_unit_env hscEnv') (hsc_all_home_unit_ids hscEnv')
-        -- TODO: Is this the right thing to do here, to produce an error for each DriverMessage generated?
         closure_err_to_multi_err err =
             ideErrorWithSource
                 (Just "cradle") (Just DiagnosticSeverity_Warning) _cfp

ghcide/src/Development/IDE/GHC/Compat/Driver.hs

@@ -70,8 +70,6 @@ hsc_typecheck keep_rn mod_summary mb_rdr_module = do
                         ioMsgMaybe $ hoistTcRnMessage $
                             tcRnMergeSignatures hsc_env hpm tc_result0 iface
                 else return tc_result0
-    -- TODO are we extracting anything when we merely instantiate a signature?
-    -- If not, try to move this into the "else" case above.
     rn_info <- extract_renamed_stuff mod_summary tc_result
     return (tc_result, rn_info)
 

ghcide/src/Development/IDE/Types/Options.hs

@@ -89,9 +89,9 @@ data OptHaddockParse = HaddockParse | NoHaddockParse
   deriving (Eq,Ord,Show,Enum)
 
 data IdePreprocessedSource = IdePreprocessedSource
-  { preprocWarnings :: [(GHC.SrcSpan, String)] -- TODO: Make these warnings structured as well
+  { preprocWarnings :: [(GHC.SrcSpan, String)] -- TODO: Future work could we make these warnings structured as well?
     -- ^ Warnings emitted by the preprocessor.
-  , preprocErrors   :: [(GHC.SrcSpan, String)] -- TODO: Make these errors structured as well
+  , preprocErrors   :: [(GHC.SrcSpan, String)] -- TODO: Future work could we make these errors structured as well?
     -- ^ Errors emitted by the preprocessor.
   , preprocSource   :: GHC.ParsedSource
     -- ^ New parse tree emitted by the preprocessor.