Skip to content

Commit 83eb07b

Browse files
committed
No longer mark tests as broken for windows GHC 9.2.7
1 parent 6b5eb41 commit 83eb07b

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

ghcide/test/exe/Main.hs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,10 +1216,6 @@ findDefinitionAndHoverTests = let
12161216
testM yes yes reexported reexportedSig "Imported symbol (reexported)"
12171217
, if | ghcVersion == GHC90 && isWindows ->
12181218
test no broken thLocL57 thLoc "TH Splice Hover"
1219-
| ghcVersion == GHC92 && (isWindows || isMac) ->
1220-
-- Some GHC 9.2 distributions ship without .hi docs
1221-
-- https://gitlab.haskell.org/ghc/ghc/-/issues/20903
1222-
test no broken thLocL57 thLoc "TH Splice Hover"
12231219
| otherwise ->
12241220
test no yes thLocL57 thLoc "TH Splice Hover"
12251221
]
@@ -2061,14 +2057,14 @@ completionDocTests =
20612057
]
20622058
let expected = "*Imported from 'Prelude'*\n"
20632059
test doc (Position 1 8) "odd" (Just $ T.length expected) [expected]
2064-
, brokenForMacGhc9 $ brokenForWinGhc9 $ testSession "extern single line doc without '\\n'" $ do
2060+
, brokenForMacGhc9 $ brokenForWinGhc90 $ testSession "extern single line doc without '\\n'" $ do
20652061
doc <- createDoc "A.hs" "haskell" $ T.unlines
20662062
[ "module A where"
20672063
, "foo = no"
20682064
]
20692065
let expected = "*Imported from 'Prelude'*\n* * *\n\n\nBoolean \"not\"\n"
20702066
test doc (Position 1 8) "not" (Just $ T.length expected) [expected]
2071-
, brokenForMacGhc9 $ brokenForWinGhc9 $ testSession "extern mulit line doc" $ do
2067+
, brokenForMacGhc9 $ brokenForWinGhc90 $ testSession "extern mulit line doc" $ do
20722068
doc <- createDoc "A.hs" "haskell" $ T.unlines
20732069
[ "module A where"
20742070
, "foo = i"
@@ -2085,7 +2081,7 @@ completionDocTests =
20852081
]
20862082
where
20872083
brokenForGhc9 = knownBrokenFor (BrokenForGHC [GHC90, GHC92, GHC94, GHC96]) "Completion doc doesn't support ghc9"
2088-
brokenForWinGhc9 = knownBrokenFor (BrokenSpecific Windows [GHC90, GHC92]) "Extern doc doesn't support Windows for ghc9.2"
2084+
brokenForWinGhc90 = knownBrokenFor (BrokenSpecific Windows [GHC90]) "Extern doc doesn't support Windows for ghc9.2"
20892085
-- https://gitlab.haskell.org/ghc/ghc/-/issues/20903
20902086
brokenForMacGhc9 = knownBrokenFor (BrokenSpecific MacOS [GHC90, GHC92, GHC94, GHC96]) "Extern doc doesn't support MacOS for ghc9"
20912087
test doc pos label mn expected = do

0 commit comments

Comments
 (0)