Skip to content

Commit 62757b4

Browse files
committed
CI: Don't fail fast
We don't want to fail fast. We used to fail fast, to avoid caches of failing PRs to overpopulate the CI caches, evicting known good build caches. However, PRs do not cache anything any more, and can only use the caches from current master. See 'caching.yml' for our caching set up.
1 parent 6e7e134 commit 62757b4

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,12 @@ jobs:
6161
- pre_job
6262
runs-on: ${{ matrix.os }}
6363
strategy:
64-
fail-fast: true
65-
# when you edit this list of GHC versions,
66-
# **don't forget**
67-
# to update the ghc versions in 'caching.yml'.
64+
# We don't want to fail fast.
65+
# We used to fail fast, to avoid caches of failing PRs to overpopulate the CI
66+
# caches, evicting known good build caches.
67+
# However, PRs do not cache anything any more, and can only use the caches from current master.
68+
# See 'caching.yml' for our caching set up.
69+
fail-fast: false
6870
matrix:
6971
ghc: ${{ fromJSON(needs.pre_job.outputs.ghcs) }}
7072
os:

0 commit comments

Comments
 (0)