Skip to content

Commit 5286ad7

Browse files
committed
ghcide: Core.Compile: spliceExpression: rm harmful DList conversion
DList tells: https://hackage.haskell.org/package/dlist-1.0/docs/src/Data.DList.Internal.html#fromList
1 parent f568fa2 commit 5286ad7

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

ghcide/src/Development/IDE/Core/Compile.hs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ import Control.Monad.Extra
7676
import Control.Monad.Trans.Except
7777
import Data.Bifunctor (second)
7878
import qualified Data.ByteString as BS
79-
import qualified Data.DList as DL
8079
import Data.IORef
8180
import Data.List.Extra
8281
import qualified Data.Map.Strict as Map
@@ -102,6 +101,7 @@ import Data.Coerce
102101
import Data.Functor
103102
import qualified Data.HashMap.Strict as HashMap
104103
import Data.Map (Map)
104+
import Data.Foldable (fold)
105105
import Data.Tuple.Extra (dupe)
106106
import Data.Either.Extra (maybeToEither)
107107
import Data.Unique as Unique
@@ -474,13 +474,13 @@ generateHieAsts hscEnv tcm =
474474

475475
spliceExpresions :: Splices -> [LHsExpr GhcTc]
476476
spliceExpresions Splices{..} =
477-
DL.toList $ mconcat
478-
[ DL.fromList $ map fst exprSplices
479-
, DL.fromList $ map fst patSplices
480-
, DL.fromList $ map fst typeSplices
481-
, DL.fromList $ map fst declSplices
482-
, DL.fromList $ map fst awSplices
483-
]
477+
fold
478+
[ map fst exprSplices
479+
, map fst patSplices
480+
, map fst typeSplices
481+
, map fst declSplices
482+
, map fst awSplices
483+
]
484484

485485
-- | In addition to indexing the `.hie` file, this function is responsible for
486486
-- maintaining the 'IndexQueue' state and notfiying the user about indexing

0 commit comments

Comments
 (0)