Flow: Enable "sketchy-number" lint rule (#1834)

IvanGoncharov · web-flow · commit dfcdce789aaf · 2019-04-27T09:23:22.000+03:00
diff --git a/.flowconfig b/.flowconfig
@@ -14,7 +14,7 @@ sketchy-null-bool=off
 sketchy-null-string=off
 sketchy-null-number=error
 sketchy-null-mixed=off
-sketchy-number=off
+sketchy-number=error
 untyped-type-import=error
 nonstrict-import=off
 untyped-import=off
diff --git a/src/validation/__tests__/PossibleTypeExtensions-test.js b/src/validation/__tests__/PossibleTypeExtensions-test.js
@@ -35,7 +35,7 @@ function extendingDifferentTypeKind(typeName, kind, l1, c1, l2, c2) {
   const message = extendingDifferentTypeKindMessage(typeName, kind);
   const locations = [{ line: l1, column: c1 }];
 
-  if (l2 && c2) {
+  if (l2 !== undefined && c2 !== undefined) {
     locations.push({ line: l2, column: c2 });
   }
   return { message, locations };

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ function extendingDifferentTypeKind(typeName, kind, l1, c1, l2, c2) {`
`35`	`35`	`const message = extendingDifferentTypeKindMessage(typeName, kind);`
`36`	`36`	`const locations = [{ line: l1, column: c1 }];`
`37`	`37`
`38`		`- if (l2 && c2) {`
	`38`	`+ if (l2 !== undefined && c2 !== undefined) {`
`39`	`39`	`locations.push({ line: l2, column: c2 });`
`40`	`40`	`}`
`41`	`41`	`return { message, locations };`