Skip to content

Commit b708225

Browse files
committed
add TODO
1 parent ed820bf commit b708225

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/execution/execute.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ const collectSubfields = memoize3(
139139
*/
140140
export interface ValidatedExecutionArgs {
141141
schema: GraphQLSchema;
142+
// TODO: consider deprecating if/when fragment arguments are officially supported
143+
// and/or are exposed within GraphQLResolveInfo.
142144
fragmentDefinitions: ObjMap<FragmentDefinitionNode>;
143145
fragments: ObjMap<FragmentDetails>;
144146
rootValue: unknown;
@@ -499,6 +501,7 @@ export function validateExecutionArgs(
499501
}
500502
break;
501503
case Kind.FRAGMENT_DEFINITION: {
504+
fragmentDefinitions[definition.name.value] = definition;
502505
let variableSignatures;
503506
if (definition.variableDefinitions) {
504507
variableSignatures = Object.create(null);
@@ -507,7 +510,6 @@ export function validateExecutionArgs(
507510
variableSignatures[signature.name] = signature;
508511
}
509512
}
510-
fragmentDefinitions[definition.name.value] = definition;
511513
fragments[definition.name.value] = { definition, variableSignatures };
512514
break;
513515
}

0 commit comments

Comments
 (0)