Flow: Remove 'any's or improve their locality (#2433)

Author: IvanGoncharov

src/error/__tests__/locatedError-test.js

@@ -19,20 +19,20 @@ describe('locatedError', () => {
   });
 
   it('passes GraphQLError-ish through', () => {
-    const e: any = new Error('I have a different prototype chain');
-    e.locations = [];
-    e.path = [];
-    e.nodes = [];
-    e.source = null;
-    e.positions = [];
-    e.name = 'GraphQLError';
+    const e = new Error('I have a different prototype chain');
+    (e: any).locations = [];
+    (e: any).path = [];
+    (e: any).nodes = [];
+    (e: any).source = null;
+    (e: any).positions = [];
+    (e: any).name = 'GraphQLError';
 
     expect(locatedError(e, [], [])).to.deep.equal(e);
   });
 
   it('does not pass through elasticsearch-like errors', () => {
-    const e: any = new Error('I am from elasticsearch');
-    e.path = '/something/feed/_search';
+    const e = new Error('I am from elasticsearch');
+    (e: any).path = '/something/feed/_search';
 
     expect(locatedError(e, [], [])).to.not.deep.equal(e);
   });

src/execution/__tests__/executor-test.js

@@ -458,10 +458,8 @@ describe('Execute: Handles basic execution tasks', () => {
         return Promise.resolve(new Error('Error getting asyncReturnError'));
       },
       asyncReturnErrorWithExtensions() {
-        const error: any = new Error(
-          'Error getting asyncReturnErrorWithExtensions',
-        );
-        error.extensions = { foo: 'bar' };
+        const error = new Error('Error getting asyncReturnErrorWithExtensions');
+        (error: any).extensions = { foo: 'bar' };
 
         return Promise.resolve(error);
       },

src/language/__tests__/visitor-test.js

@@ -867,8 +867,8 @@ describe('Visitor', () => {
   });
 
   describe('Support for custom AST nodes', () => {
-    const customAST: any = parse('{ a }');
-    customAST.definitions[0].selectionSet.selections.push({
+    const customAST = parse('{ a }');
+    (customAST: any).definitions[0].selectionSet.selections.push({
       kind: 'CustomField',
       name: {
         kind: 'Name',
@@ -916,10 +916,8 @@ describe('Visitor', () => {
     });
 
     it('does not traverse unknown node kinds', () => {
-      const customQueryDocumentKeys: any = {
-        ...QueryDocumentKeys,
-        CustomField: ['name', 'selectionSet'],
-      };
+      const customQueryDocumentKeys = { ...QueryDocumentKeys };
+      (customQueryDocumentKeys: any).CustomField = ['name', 'selectionSet'];
 
       const visited = [];
       const visitor = {

src/polyfills/flatMap.js

@@ -5,8 +5,7 @@ declare function flatMap<T, U>(
   fn: (item: T, index: number) => $ReadOnlyArray<U> | U,
 ): Array<U>;
 
-// Workaround to make older Flow versions happy
-const flatMapMethod = (Array.prototype: any).flatMap;
+const flatMapMethod = Array.prototype.flatMap;
 
 /* eslint-disable no-redeclare */
 // $FlowFixMe

src/utilities/extendSchema.js

@@ -404,10 +404,7 @@ export function extendSchemaImpl(
     mutation: ?GraphQLObjectType,
     subscription: ?GraphQLObjectType,
   |} {
-    // Note: While this could make early assertions to get the correctly
-    // typed values below, that would throw immediately while type system
-    // validation with validateSchema() will produce more actionable results.
-    const opTypes: any = {};
+    const opTypes = {};
     for (const node of nodes) {
       /* istanbul ignore next (See https://github.com/graphql/graphql-js/issues/2203) */
       const operationTypesNodes = node.operationTypes ?? [];
@@ -416,7 +413,11 @@ export function extendSchemaImpl(
         opTypes[operationType.operation] = getNamedType(operationType.type);
       }
     }
-    return opTypes;
+
+    // Note: While this could make early assertions to get the correctly
+    // typed values below, that would throw immediately while type system
+    // validation with validateSchema() will produce more actionable results.
+    return (opTypes: any);
   }
 
   function getNamedType(node: NamedTypeNode): GraphQLNamedType {

src/validation/rules/UniqueDirectivesPerLocationRule.js

@@ -3,7 +3,6 @@
 import { GraphQLError } from '../../error/GraphQLError';
 
 import { Kind } from '../../language/kinds';
-import { type DirectiveNode } from '../../language/ast';
 import { type ASTVisitor } from '../../language/visitor';
 
 import { specifiedDirectives } from '../../type/directives';
@@ -44,12 +43,9 @@ export function UniqueDirectivesPerLocationRule(
     // them all, just listen for entering any node, and check to see if it
     // defines any directives.
     enter(node) {
-      // Flow can't refine that node.directives will only contain directives,
-      // so we cast so the rest of the code is well typed.
-      const directives: ?$ReadOnlyArray<DirectiveNode> = (node: any).directives;
-      if (directives) {
+      if (node.directives != null) {
         const knownDirectives = Object.create(null);
-        for (const directive of directives) {
+        for (const directive of node.directives) {
           const directiveName = directive.name.value;
 
           if (uniqueDirectiveMap[directiveName]) {